Remove Mappable, JSON, Parse and Serialize 🚮
#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of `Codable` that `Mappable` became deprecated, but for one reason or another we didn't remove it. That time has come. As the `JSON`, `Parse` and `Serialize` "namespaces" are tightly coupled to the `Mappable` protocol, they have also been removed. The exception was `UIImage` encoding/decoding to/from `Data`, but that can easily be done by using native APIs like `pngData()`/`jpegData(compressionQuality:)` or `UIImage.init(data:)`, respectively. Closes #119 (finally 😅). ## Changes - Remove `Mappable`. - Remove `JSON`, `Parse` and `Serialize` namespaces and helpers.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 94.94% 94.82% -0.13%
==========================================
Files 102 97 -5
Lines 3345 3190 -155
==========================================
- Hits 3176 3025 -151
+ Misses 169 165 -4 Continue to review full report at Codecov.
|
filipe-lemos
approved these changes
Sep 30, 2020
ricardomsm
approved these changes
Sep 30, 2020
tiagoalexbastos
approved these changes
Oct 1, 2020
diogoeiras
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Since the introduction of
CodablethatMappablebecame deprecated, but for one reason or another we didn't remove it. That time has come.As the
JSON,ParseandSerialize"namespaces" are tightly coupled to theMappableprotocol, they have also been removed. The exception wasUIImageencoding/decoding to/fromData, but that can easily be done by using native APIs likepngData()/jpegData(compressionQuality:)orUIImage.init(data:), respectively.Closes #119 (finally 😅).
Description
Remove
Mappable.Remove
JSON,ParseandSerializenamespaces and helpers.