8000 Document declaring dynamic param without RuntimeDefinedParameterDictionary by dkattan · Pull Request #10547 · MicrosoftDocs/PowerShell-Docs · GitHub
[go: up one dir, main page]

Skip to content

Document declaring dynamic param without RuntimeDefinedParameterDictionary #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dkattan
Copy link
@dkattan dkattan commented Oct 19, 2023

PR Summary

Corresponds to PowerShell/PowerShell#20446

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

dkattan and others added 2 commits October 19, 2023 10:54
Added documentation for declaring dynamic parameters without RuntimeDefinedParameterDictionary
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit aec7323:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/CimCmdlets/CimCmdlets.md ✅Succeeded
reference/7.5/CimCmdlets/Get-CimAssociatedInstance.md ✅Succeeded
reference/7.5/CimCmdlets/Get-CimClass.md ✅Succeeded
reference/7.5/CimCmdlets/Get-CimInstance.md ✅Succeeded
reference/7.5/CimCmdlets/Get-CimSession.md ✅Succeeded
reference/7.5/CimCmdlets/Invoke-CimMethod.md ✅Succeeded
reference/7.5/CimCmdlets/New-CimInstance.md ✅Succeeded
reference/7.5/CimCmdlets/New-CimSession.md ✅Succeeded
reference/7.5/CimCmdlets/New-CimSessionOption.md ✅Succeeded
reference/7.5/CimCmdlets/Register-CimIndicationEvent.md ✅Succeeded
reference/7.5/CimCmdlets/Remove-CimInstance.md ✅Succeeded
reference/7.5/CimCmdlets/Remove-CimSession.md ✅Succeeded
reference/7.5/CimCmdlets/Set-CimInstance.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Archive/Compress-Archive.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Archive/Expand-Archive.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Archive/Microsoft.PowerShell.Archive.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/.markdownlint.yaml ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/About.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Alias_Provider.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Aliases.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_ANSI_Terminals.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Arithmetic_Operators.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Arrays.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Assignment_Operators.md ✅Succeeded
reference/7.5/Microsoft.PowerShell.Core/About/about_Automatic_Variables.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@github-actions
Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for me 8000 rge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@sdwheeler
Copy link
Collaborator

@dkattan I can't take this PR in this state. Please remove the 7.5 content and only include the changes to about_Functions_Advanced_Parameters.md.

@sdwheeler sdwheeler added the do-not-merge Tag - closed without merging label Oct 19, 2023
@sdwheeler
Copy link
Collaborator

@dkattan After further review, I see that the changes you are making to about_Functions_Advanced_Parameters.md are dependent on a PR that has not been merged, or even reviewed yet. This docs PR is premature.

I am closing this PR for now. If the code change gets approved and merged, then we can look at adding the appropriate documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Tag - closed without merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0