Hwy dynamic dispatch #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in
2F6A
a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Currently broken. I can verify that the individual SIMD-accelerated functions work, however the dynamic dispatch mechanism doesn't seem to be working. Not sure where to go.
Specifically,
simd_manhattan_distshould be usable but at runtime there is an import error reporting a missing symbol for it. I can verify that indeed there is no appropriate symbol for it inlibavx_dist_metrics.aorsimd.o.Also, I'm not sure if there's a nicer way to handle dynamic dispatch on a type-templated function than what I currently have (
HWY_EXPORTmakes this a bit difficult since the template specification gets absorbed into a variable name upon expansion)