Support more search params for TypeScript client #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the TypeScript client's memory search capabilities by adding context expansion and score threshold parameters, introduces a new method to retrieve Prometheus metrics, and updates the package version to 0.2.5.
Changes:
- Added
expand_contextandscore_thresholdparameters to memory search options - Introduced
getMetrics()method to retrieve Prometheus metrics from the server - Updated package version from 0.0.1 to 0.2.5 and repository URL format
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/memmachine-ts/rest_client/src/memory/memmachine-memory.types.ts | Added type definitions for new search parameters |
| src/memmachine-ts/rest_client/src/memory/memmachine-memory.ts | Integrated new search parameters into the search payload |
| src/memmachine-ts/rest_client/src/client/memmachine-client.ts | Added getMetrics() method for Prometheus metrics retrieval |
| src/memmachine-ts/rest_client/tests/memmachine-client.spec.ts | Added test coverage for the new getMetrics() method |
| src/memmachine-ts/rest_client/package.json | Updated version and repository URL |
| src/memmachine-ts/rest_client/README.md | Updated documentation to include getMetrics() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Support context expansion and score threshold params for search Support retrieving Prometheus metrics from MemMachine server Bump ts client version to 0.2.5
666d686 to
4e118c6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Adds support for context expansion and score threshold search parameters, and enables retrieving Prometheus metrics from the MemMachine server.
Description
This change adds support for context expansion and score threshold parameters to the memory search functionality in the TypeScript client. It also introduces a method to retrieve Prometheus metrics from the MemMachine server. Additionally, it updates the client version to 0.2.5.
Type of change
How Has This Been Tested?
Test Results:
Checklist
Maintainer Checklist