[GH-943] Simplify Episode store add_episodes #989
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the add_episodes method in the Episode SQLAlchemy store by reducing database operations and removing unnecessary data transformations that were causing KeyError exceptions.
Changes:
- Modified the insert statement to return complete Episode objects instead of just IDs
- Eliminated the second database session and SELECT query that was previously used to retrieve full episode data
- Removed the intermediate dictionary mapping step that was prone to KeyError issues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/memmachine/common/episode_store/episode_sqlalchemy_store.py
Outdated
Show resolved
Hide resolved
46a249e to
12506a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Simplify Episode Store
add_episodelogic.Remove multiple transactions and remapping Episodes. Fixing KeyError.
Fixes #943