8000 WIP: Update LoCoMo evaluation scripts by edwinyyyu · Pull Request #651 · MemMachine/MemMachine · GitHub
[go: up one dir, main page]
Skip to content

WIP: Update LoCoMo evaluation scripts #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
edwinyyyu wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Update LoCoMo evaluation scripts #651

edwinyyyu wants to merge 1 commit into from

Conversation

@edwinyyyu
Copy link
Contributor
@edwinyyyu edwinyyyu commented Dec 1, 2025 •
edited
Loading

Purpose of the change

Update LoCoMo evaluation scripts for improved performance and to work with new (internal) APIs.

Description

WIP. Uses internal APIs to test long-term memory in isolation.

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

WIP

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Test Results: [Attach logs, screenshots, or relevant output]

Checklist

[Please delete options that are not relevant.]

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu edwinyyyu force-pushed the update_evaluation branch 7 times, most recently from 33fc9dc to 3093e29 Compare December 3, 2025 22:11
@edwinyyyu edwinyyyu force-pushed the update_evaluation branch 3 times, most recently from 384d4cd to 41f8250 Compare December 4, 2025 20:02
@edwinyyyu edwinyyyu requested a review from tomw-mv December 5, 2025 00:16
@edwinyyyu
Update LoCoMo evaluation scripts
4c628b6 
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu mentioned this pull request Dec 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malatewang malatewang Awaiting requested review from malatewang

@jgong jgong Awaiting requested review from jgong

@o-love o-love Awaiting requested review from o-love

@Tianyang-Zhang Tianyang-Zhang Awaiting requested review from Tianyang-Zhang

@tomw-mv tomw-mv Awaiting requested review from tomw-mv

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edwinyyyu
0