fix: Couple of tests are permanently broken while running locally #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous value 1572851662.9782631 corresponded 04.11.2019 10:14:22, not 03.11.2019 23:14:22 as written in comments |
IlyaFaer
reviewed
Sep 21, 2020
| @@ -52,7 +52,7 @@ def test_DateFromTicks(self): | |||
| ) | |||
|
|
|||
| def test_TimeFromTicks(self): | |||
| epochTicks = 1572851662.9782631 # Sun Nov 03 23:14:22 2019 | |||
| epochTicks = 1572812062.9782631 # Sun Nov 03 23:14:22 2019 | |||
There was a problem hiding this comment.
@mf2199, I've got such a failure on Windows, and @tina80lvl reproduced it on Linux, so it looks like a solution.
Still, as it never failed on kokoro, we probably should check it with draft PR to be sure
|
Link to #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.