8000 Allow symfony 4 by ragboyjr · Pull Request #1 · Majkl578/symfony-guzzle-psr7-bridge · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Allow symfony 4 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow symfony 4 #1

wants to merge 1 commit into from

Conversation

ragboyjr
Copy link

Signed-off-by: RJ Garcia rj@bighead.net

@ragboyjr
Allow symfony 4
7878cc7 
Signed-off-by: RJ Garcia <rj@bighead.net>
@Majkl578
Copy link
Owner

Hi, thanks for the PR. Can you please check the CI failures? It seems to be broken by some changes in Symfony 3.3 and also 3.4. :/

@ragboyjr
Copy link
Author

np, will check on this later on. thanks

@vhenzl
Copy link
vhenzl commented Apr 5, 2018

CI failure seems to be caused by symfony/symfony#22124 (and symfony/symfony#22036). If Response created without Date header, it's set automatically.

A solution could be to set Date header for all test cases, not sure about testCleanResponse though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragboyjr @Majkl578 @vhenzl
0