branding img optimizations #211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
i didnt check if the branding image in the readme is the same as one of the files in the repo as this was done in CLI only without a x server and lack of time also. Pulled the image from imgur and added into branding dir with same name. if file can be removed and one of the original used instead, please feel free to make changes/rebuikd this pr... Thanks |
IAmJSD
approved these changes
Aug 5, 2020
IAmJSD
requested changes
Aug 5, 2020
Member
There was a problem hiding this comment.
Actually on further thought I don't really like the idea of removing the branding files from the project due to future migrations.
Author
|
It wasnt removing any files from the project, rather using github raw url directly to the project source repo. I have reverted the doc changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raster optimizations.
use if jeeded or close if not