This repository was archived by the owner on Feb 14, 2023. It is now read-only.
Run check_manifest #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Aug 25, 2019
Also move to after_success to avoid any dependency contamination
I need to explicitly ignore both directories and their contents!
|
Seems we're running it in the wrong directory... |
|
This does not pass locally for me with: lists of files in version control and sdist do not match!
missing from VCS:which includes all the generated c files from Cython and generated py files used for deprecation. |
|
Is there a way to make "missing from VCS" non-fatal? |
|
Not possible yet: mgedmin/check-manifest#58 We can try work around this by dynamically getting the files that are generated, which will be passed into |
|
We might still want to make it work and adapt it to the new CD infra in https://github.com/scikit-learn/scikit-learn/blob/master/.github/workflows/wheels.yml. |
|
As a reference: There is a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the result of adding check-manifest to the the CI pipeline.