8000 freeze scikit-learn & min py 3.7 by Borda · Pull Request #1042 · Lightning-AI/torchmetrics · GitHub
[go: up one dir, main page]
Skip to content

freeze scikit-learn & min py 3.7 #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 23, 2022
Merged

freeze scikit-learn & min py 3.7 #1042

merged 13 commits into from
May 23, 2022

Conversation

Borda
Copy link
Member
@Borda Borda commented May 23, 2022 •
edited
Loading

What does this PR do?

Fixes metrics.precision_recall_curve to compute precision-recall at 100% recall. The Precision-Recall curve now displays the last point corresponding to a classifier that always predicts the positive class: recall=100% and precision=class balance.

API change dressed as fake bug-fix: scikit-learn/scikit-learn#23214

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug / fix Something isn't working test / CI testing or CI labels May 23, 2022
@Borda Borda marked this pull request as ready for review May 23, 2022 09:49
@codecov
Copy link
codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #1042 (72d9581) into master (3001985) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #1042    +/-   ##
=======================================
+ Coverage      91%     95%    +4%     
=======================================
  Files         181     181            
  Lines        7873    7873            
=======================================
+ Hits         7149    7468   +319     
+ Misses        724     405   -319

@Borda Borda changed the title freeze scikit-learn freeze scikit-learn & min py 3.7 May 23, 2022
@Borda Borda enabled auto-merge (squash) May 23, 2022 13:02
@mergify mergify bot added the ready label May 23, 2022
@Borda Borda disabled auto-merge May 23, 2022 15:15
@Borda Borda merged commit f51d238 into master May 23, 2022
@Borda Borda deleted the ci/fix branch May 23, 2022 15:15
@Borda Borda mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees
No one assigned
Labels
bug / fix Something isn't working ready test / CI testing or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @justusschock @kaushikb11
0