8000 Add typing for `LoggerConnector` [2/3] by carmocca · Pull Request #9270 · Lightning-AI/pytorch-lightning · GitHub
[go: up one dir, main page]
Skip to content

Add typing for LoggerConnector [2/3] #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2021
Merged

Add typing for LoggerConnector [2/3] #9270

merged 5 commits into from
Sep 2, 2021

Conversation

carmocca
Copy link
Contributor
@carmocca carmocca commented Sep 2, 2021 •
edited
Loading

What does this PR do?

Part of #5023

Links:

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 2, 2021
@carmocca carmocca self-assigned this Sep 2, 2021
@carmocca carmocca changed the title Add typing for LoggerConnector Add typing for LoggerConnector [2/3] Sep 2, 2021
This was referenced Sep 2, 2021
Merged
Merged
tchaton
tchaton approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor
@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

awaelchli
awaelchli approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor
@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do you get the stamina for this ...

@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2021
@carmocca @awaelchli
Update pytorch_lightning/utilities/memory.py
b34cc20 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@carmocca carmocca enabled auto-merge (squash) September 2, 2021 11:24
@carmocca
Copy link
Contributor Author
carmocca commented Sep 2, 2021

where do you get the stamina for this ...

I asked you guys to fully type any new pieces of code added.
Just trying to fulfill my own request.

tchaton
tchaton approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor
@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link
codecov bot commented Sep 2, 2021

Codecov Report

Merging #9270 (b34cc20) into master (a451997) will decrease coverage by 0%.
The diff coverage is 98%.

@@          Coverage Diff           @@
##           master   #9270   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         176     176           
  Lines       14819   14831   +12     
======================================
+ Hits        13666   13677   +11     
- Misses       1153    1154    +1

Borda
Borda approved these changes Sep 2, 2021
View reviewed changes
@carmocca carmocca merged commit ddb4dc2 into master Sep 2, 2021
@carmocca carmocca deleted the typing/logger-connector branch September 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @Borda @tchaton
0