This repository was archived by the owner on Jun 16, 2022. It is now read-only.
[LIVE-2186]: Bugfix - Fix NFT send making the app crash in prod (again) #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5269d7a to
7d7ed62
Compare
ghost
approved these changes
May 2, 2022
henri-ly
approved these changes
May 2, 2022
henri-ly
reviewed
May 2, 2022
| children: (props: { isOpen: ?boolean, value: ?DropDownItemType }) => React$Node, | ||
| items: DropDownItemType[], | ||
| children: (props: { isOpen: ?boolean, value: ?DropDownItemType<> }) => React$Node, | ||
| items: DropDownItemType<>[], |
There was a problem hiding this comment.
Do we really need <> ?
Isn't putting nothing put any by default ? (just asking because i find this weird but if it's not possible it's fine)
There was a problem hiding this comment.
Yes looks like it... I tried but looks like Flowtype is enforcing it for generic types even with a default value 😞
valpinkman
approved these changes
May 2, 2022
Merged
valpinkman
added a commit
that referenced
this pull request
May 3, 2022
* release/2.41.x: (56 commits) v2.41.3 Fix NFT send making the app crash in prod (again) (#4958) v2.41.2 Update to LLC 22.0.3 FIX LIVE-2186 - Fix NFT crashing the app on send (#4953) Remove @ledgerhq/ledger-core again after bad merge (#4951) Update to temp LLC dependency + @LedgerHQ libs FIX LIVE-2176 - Fix NFT Crumb (#4950) v2.41.1 Update LLC dependency LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938) v2.41.0 update screenshots (windows) update screenshots (linux) New Crowdin updates (#4913) Add LLC#22.0.1 dependency Update links to use the new explorer from metadata (#4912) Bugfix: Solana linting (#4902) [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899) LIVE-1751 Solana staking (#4884) ...
valpinkman
added a commit
that referenced
this pull request
May 3, 2022
* release/2.41.x: (31 commits) v2.41.3 Fix NFT send making the app crash in prod (again) (#4958) v2.41.2 Update to LLC 22.0.3 FIX LIVE-2186 - Fix NFT crashing the app on send (#4953) Remove @ledgerhq/ledger-core again after bad merge (#4951) Update to temp LLC dependency + @LedgerHQ libs FIX LIVE-2176 - Fix NFT Crumb (#4950) v2.41.1 Update LLC dependency LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938) v2.41.0 update screenshots (windows) update screenshots (linux) New Crowdin updates (#4913) Add LLC#22.0.1 dependency Update links to use the new explorer from metadata (#4912) Bugfix: Solana linting (#4902) [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899) LIVE-1751 Solana staking (#4884) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-2186
💻 Description / Demo (image or video)
Sending from Collection page
Screen.Recording.2022-05-02.at.15.47.51.mov
Sending from Gallery page
Screen.Recording.2022-05-02.at.15.50.15.mov
Sending from Drawer
Screen.Recording.2022-05-02.at.16.04.50.mov
Sending from outsite the live in Collection page
Screen.Recording.2022-05-02.at.16.10.54.mov
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!