8000 Playwright upgrade to 1.21.1 by mcoursier-ledger · Pull Request #4825 · LedgerHQ/ledger-live-desktop · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 16, 2022. It is now read-only.

Playwright upgrade to 1.21.1 #4825

Merged
merged 34 commits into from
Apr 27, 2022
Merged

Playwright upgrade to 1.21.1 #4825

merged 34 commits into from
Apr 27, 2022

Conversation

mcoursier-ledger
Copy link
Contributor
@mcoursier-ledger mcoursier-ledger commented Mar 8, 2022 •
edited by ggilchrist-ledger
Loading

🦒 Context (issues, jira)

https://ledgerhq.atlassian.net/browse/B2CQA-80
This PR aims at upgrading playwright to latest version known (1.20.2) 1.21.1.
Thanks to this, we are now able to make soft assertions. (won't stop test execution but it ends in error)
These soft assertions will be especially useful in the context of screenshots.

@mcoursier-ledger mcoursier-ledger requested review from a team as code owners March 8, 2022 15:47
thomasrogerlux
thomasrogerlux approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor
@thomasrogerlux thomasrogerlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@github-actions
Copy link
github-actions bot commented Mar 29, 2022 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1fc8deb

@alalmi-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@nabil-brn
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@nabil-brn
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@nabil-brn nabil-brn changed the title Playwright upgrade to 1.19 Playwright upgrade to 1.20.2 Apr 12, 2022
@github-actions
Copy link

Generating new screenshots

@nabil-brn
Copy link
Contributor
nabil-brn commented Apr 12, 2022 •
edited
Loading

Okay I thing we're good, only this flaky test is remaining, let's wait tomorow to find a solution about this annoying tooltip.

@ggilchrist-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@ggilchrist-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@ggilchrist-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@mcoursier-ledger mcoursier-ledger requested a review from a team as a code owner April 27, 2022 08:50
@ggilchrist-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@ggilchrist-ledger
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@ggilchrist-ledger ggilchrist-ledger changed the title Playwright upgrade to 1.20.2 Playwright upgrade to 1.21.1 Apr 27, 2022
@ggilchrist-ledger ggilchrist-ledger merged commit 39f34ba into develop Apr 27, 2022
@ggilchrist-ledger ggilchrist-ledger deleted the B2CQA-80_upgradePlaywright branch April 27, 2022 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valpinkman valpinkman valpinkman approved these changes

@thomasrogerlux thomasrogerlux thomasrogerlux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mcoursier-ledger @alalmi-ledger @nabil-brn @ggilchrist-ledger @valpinkman @thomasrogerlux @ledgerlive
0