Conversation
|
closes #4 |
github integration is now updated as of 2016. update copyright date.
|
@reverentgeek signing you up for updating leankit integration support docs. if only it was gh-pages.... |
- switch github.com vs github enterprise based on host configuration - abstract logic into helper function - switch rest api url based on enterprise or .com - start working on whitespace/indention issues
|
Why does GitHubIssuesSubSystem and GitHubPullsSubsystem not use GitHubConnection to access GitHub? Seems redundant, but maybe there's a reason...? |
|
The current assumption in the Integration Service is the To support both github.com and Enterprise customers, I think we'll have to change the expected input to be either When making API requests to Enterprise, I understand the api path starts with You're right, GitHubIssuesSubsystem and GitHubPullsSubsystem could probably be refactored to use GitHubConnection. That was probably on our list at one time, but never got around to it. |
|
good details.
Ahh, that makes sense. I couldn't understand what that line in the docs was trying to say. Actually enterprise will work the same way as github.com (in the sense of I'm not sure what sort of templating engine is being used for the web-frontend, but would it be possible to extend with additional form fields or cascading selection options? (ie, ask for a repo owner/organization seperately from a github url)?
Just wasn't sure if they was a specific reason for this that I wasn't understanding. 👍 |
🚧 Work in progress 🚧
NOTE: I haven't written C# in 10+ years, so i'm starting with pretty close pseudo-code, and i'll figure out proper C# bits later.
Tasking