Proposal: add a dl method to HtmlBuilder #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method generates a description list of items.
|
PS: thanks for maintaining the html/form classes and keeping them alive |
|
Can you please use tabs instead of spaces? |
|
ok |
RobinMalfait
added a commit
that referenced
this pull request
Feb 19, 2015
Proposal: add a dl method to HtmlBuilder
|
Thanks for merging this in. However now that I am looking at it I see that the attributes argument uses [] as the default array as apposed to array() like everything else. Perhaps that should be changed for consistency? |
|
@devinfd since this package requires 5.4, everything else should be changed to the short array syntax, just like Laravel 5. Speaking of consistency, why is the test file indented with spaces? |
|
Your right about the 5.4 thing. I forgot about that. As for the test file I would have preferred tabs but I was trying to keep the tests consistent with the form builder test file. Personally I would like to make them both tabs and add more tests to the html builder test file but I didn't want to bumbard you with changes. |
jcanchor
pushed a commit
to jcanchor/html
that referenced
this pull request
Apr 28, 2023
FIxed a bug when using csrf on latest Laravel 5 build. ``` [2014-10-16 14:27:25] production.ERROR: exception 'Illuminate\Session\TokenMismatchException' in /Users/crynobone/Sites/sandbox/app/Http/Middleware/CsrfMiddleware.php:24 Stack trace: #0 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): App\Http\Middleware\CsrfMiddleware->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#1 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/View/Middleware/ErrorBinder.php(55): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#2 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): Illuminate\View\Middleware\ErrorBinder->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#3 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(8884): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#4 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): Illuminate\Session\Middleware\Writer->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#5 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(8850): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#6 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): Illuminate\Session\Middleware\Reader->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#7 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(9453): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#8 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): Illuminate\Cookie\Middleware\Queue->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#9 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(9401): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#10 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): Illuminate\Cookie\Middleware\Guard->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#11 /Users/crynobone/Sites/sandbox/app/Http/Middleware/GuestMiddleware.php(40): Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#12 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(73): App\Http\Middleware\MaintenanceMiddleware->handle(Object(Illuminate\Http\Request), Object(Closure)) LaravelCollective#13 [internal function]: Illuminate\Routing\Stack\Stack->Illuminate\Routing\Stack\{closure}(Object(Illuminate\Http\Request)) LaravelCollective#14 /Users/crynobone/Sites/sandbox/vendor/laravel/framework/src/Illuminate/Routing/Stack/Stack.php(59): call_user_func(Object(Closure), Object(Illuminate\Http\Request)) LaravelCollective#15 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(983): Illuminate\Routing\Stack\Stack->run(Object(Illuminate\Http\Request)) LaravelCollective#16 /Users/crynobone/Sites/sandbox/storage/framework/compiled.php(964): Illuminate\Foundation\Application->handleRequest(Object(Illuminate\Http\Request)) LaravelCollective#17 /Users/crynobone/Sites/sandbox/public/index.php(49): Illuminate\Foundation\Application->run() LaravelCollective#18 {main} [] [] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method generates a description list of items.