General platform-logic refactoring & Haiku support. #1827
Conversation
|
This looks pretty good, but something has broken our win32 builds per: -Tres |
|
There, that should fix shared memory on Windows. |
|
👍 Since this adds a new |
|
In lb302, it'd be better to just remove that MIN macro completely and replace it with qMin() to be consistent with rest of our codebase. |
|
Done. |
| @@ -34,7 +34,7 @@ | |||
| #include <cmath> | |||
| using namespace std; | |||
|
|
|||
| #if defined (LMMS_BUILD_WIN32) || defined (LMMS_BUILD_APPLE) | |||
| #if defined (LMMS_BUILD_WIN32) || defined (LMMS_BUILD_APPLE) || defined(LMMS_BUILD_HAIKU) | |||
There was a problem hiding this comment.
As I wrote in #1822, I think this #if condition can just be removed and its body enabled on all platforms.
There was a problem hiding this comment.
Except some OSes may not have these as #defines, so you'll be overriding the OS version.
|
@waddlesplash thanks as this cleans things up quite a bit. We'll tag this commit if we have any fallout from a VST perspective. Merging. |
General platform-logic refactoring & Haiku support.
Fixes #1820.