10000 Introducing Spack environments by ldowen · Pull Request #331 · LLNL/spheral · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Spack environments #331

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Introducing Spack environments #331

wants to merge 22 commits into from

Conversation

ldowen
Copy link
Collaborator
@ldowen ldowen commented Feb 7, 2025 •
edited
Loading

Summary

  • This PR is a refactor of how Spack is used by Spheral
  • It does the following:
    • Removes all use of uberenv.
    • Adds Spack environments.
    • Centralizes TPL designations like upstream location.
    • Adds logic to make installing Spheral TPLs outside of LC easier:
      • Uses spack external find and spack compiler find to avoid installing existing TPLs on the system.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#129)
  • LLNLSpheral PR has passed all tests.

ldowen added 5 commits February 3, 2025 16:37
@ldowen
Removed uberenv related aspects, removed build_and_install.py, added …
b38a14f 
…environments and related functionality
@ldowen
Fix typo in tpl-manager
6bbea25
@ldowen
Fix typo in gitlab/scripts.yml
603c75b
@ldowen
Upstream now set in a separate file, added --dev-specs option to tpl-…
aa03795 
…manager, changed tpl-manager to use more spack python calls, config file name is taken directly from spack package for consistency, specs must be complete and not just variants and compilers, updated shell and gitlab files based on spec change, cleaned up gitignore
@ldowen
Merge branch 'develop' into feature/spack_envs
ff9847c
@ldowen ldowen requested review from jmikeowen and mdavis36 February 7, 2025 22:37
@ldowen ldowen self-assigned this Feb 7, 2025
mdavis36
mdavis36 requested changes Feb 10, 2025
View reviewed changes
scripts/devtools/tpl-manager.py Outdated Show resolved Hide resolved
scripts/lc/install-from-dev-pkg.sh Show resolved Hide resolved
mdavis36
mdavis36 requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator
@mdavis36 mdavis36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this touches our update-tpl and release process we will want to run pipelines for both of those before merging this PR to validate they are working as expected. Can we also get the new documentation built on RTD for review there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdavis36 mdavis36 mdavis36 requested changes

@jmikeowen jmikeowen Awaiting requested review from jmikeowen

Requested changes must be addressed to merge this pull request.

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldowen @mdavis36
0