10000 Splitting Artificial viscosity out of hydrodynamics packages into its own physics package by jmikeowen · Pull Request #317 · LLNL/spheral · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting Artificial viscosity out of hydrodynamics packages into its own physics package #317

Open
wants to merge 86 commits into
base: develop
Choose a base branch
from
Open

Splitting Artificial viscosity out of hydrodynamics packages into its own physics package #317

wants to merge 86 commits into from
+8,386 −11,539

Conversation

jmikeowen
Copy link
Collaborator
@jmikeowen jmikeowen commented Dec 4, 2024 •
edited
Loading

Summary

  • This PR is a feature/refactoring
  • It does the following:
    • Make the ArtificialViscosity it's own physics package, working alongside the hydrodynamics package.
    • Cleans up some state usage, particularly being more rigorous about some of the artificial viscosity logic correctly time centering it's dependent state during a time advancement cycle.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen
Moving grad-h corrections to SPH::postStateUpdate to avoid mixing tim…
30d1444 
…e-levels in multi-stage integrators
@jmikeowen
Parameter change in interpolation kernel (no real change)
af2c1b1
@jmikeowen
Converted NodePairList storage in ConnectivityMap to be a shared_ptr
9a22af9
@jmikeowen
Convert NodePairList to use size_t
faf2546
@jmikeowen
Split up the NodePairIdxType and NodePairList into separate headers,
e510788 
and adding an index of NodePair->index lookup map.
@jmikeowen
Initial introduction of PairwiseField. Also split out NodePairIdxType
d83759d 
from the NodePairList header.
@jmikeowen
Using the pair->index lookup computed by NodePairList
d3093c2
@jmikeowen
Interim checkin
f8ac3a9
@jmikeowen
Lot of renaming
6a5c976
@jmikeowen
Converting SPH classes to use PairwiseField for pair-accelerations.
7b55da6 
And some other cleanup...
@jmikeowen
Updating Python front-end constructor
f41931e
@jmikeowen
Initial conversion of SPH PYB11 package (untested)
56c4dd8
@jmikeowen
Updating thermal energy policies for PairwiseField use
04af076
@jmikeowen
Fixing some DataTypeTraits zeros, and making Python better respect co…
7f339ad 
…nfiguration choices such as which hydros to build.
@jmikeowen
SPH can now run using PairwiseField for pair accelerations, but the i…
0a08b64 
…nitialization order is not great
@jmikeowen
Merge branch 'develop' into bugfix/EvalDerivCleanup
b47d696
@jmikeowen
Making State and StateDerivatives not default constructable
83c46a1
@jmikeowen
Changing initialization order in Integrators and DataBase such that
92f85b8 
the ConnectivtyMap is available during construction of the State and
StateDerivatives. This is necessary to support pair-wise fields as
state members.
@jmikeowen
Clean up unused method
11d4e8a
@jmikeowen
Fixing a comment in SPH, and starting to convert CRK
89bd714
@jmikeowen
Simplifying dependencies for postion update, eps, and RZ cases
844414a
@jmikeowen
Initial conversion of CRKSPH to newer interface with PairwiseField
da23e11
@jmikeowen
Some SPH fixes with new interface
6cc6e02
@jmikeowen
PSPH needs to start inconsistently (need to fix this)
e576f2e
@jmikeowen
Got PSPH functioning
28625e3
@jmikeowen
FSISPH converted to PairwiseFields
2aa7d14
@jmikeowen
Converted GSPH to PairwiseField
09fc4 10000 29
@jmikeowen
Moved how we build the State to be robust when not running a full
909bacb 
problem using the SpheralController
@jmikeowen
Removed unused option filter
2f09aeb
@jmikeowen
Fixed incorrect contract
6ebdba6
@jmikeowen jmikeowen marked this pull request as ready for review February 11, 2025 00:31
@jmikeowen
- Moving how artificial visocosity handles updating the velocity
57bbe02 
gradient.  Rigorous computation now happens in the pre-derivative
initialize, while copying the last hydro value is still in the
postStateUpdate.
- Making Physics::initialize return a bool now indicating if boundary
conditions should be applied, similar to Physics::postStateUpdate.
- Cleaned up how Integrator handles the boundary condition application
for initialize and postStateUpdate.  Also made more Integrator methods const.
@jmikeowen
Being more precise about how we handle the AV velocity gradient throu…
4a0fdbd 
…gh a physics step
@jmikeowen
Fixes for writing reference state for SpheralC testing
97d8d48
@jmikeowen
Splitting up initialization work in RK
ace9447
jmpearl
jmpearl reviewed Feb 19, 2025
View reviewed changes
src/CRKSPH/CRKSPHBase.hh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptsuji ptsuji ptsuji left review comments

@jmpearl jmpearl jmpearl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmikeowen @ptsuji @jmpearl @mdavis36 @ldowen
0