Its #34
Its #34
Conversation
When job is null, then trigger useless.
| @@ -408,6 +413,10 @@ private static boolean isSupportedTriggerMode(GitHubPRTriggerMode mode) { | |||
| } | |||
| } | |||
|
|
|||
| public Job<?, ?> getJob() { | |||
There was a problem hiding this comment.
Remove usage of generic wildcard type. 
Remove usage of generic wildcard type.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| @@ -0,0 +1,23 @@ | |||
| package org.jenkinsci.plugins.github_integration; | |||
There was a problem hiding this comment.
packages with underlines looks ugly
There was a problem hiding this comment.
either it will be under github. that will conflict with too generic github-plugin. Done in the same way as github-branchsource
There was a problem hiding this comment.
If it be under .github.integration as base package will be no conflicts i think
There was a problem hiding this comment.
jenkinsci/github-branch-source-plugin#1
Logging will overlap
There was a problem hiding this comment.
I would like rename plugin classes near some 1.0 release to exclude logging overlap between plugins. Existed code will keep as is, new under other package.
|
SonarQube analysis reported 2 issues:
Watch the comments in this conversation to review them. |
|
Thanks to @tfennelly for help. Workflow roundTrip still doesn't work, by i bypassed it. |
No description provided.