8000 Rename of test file to allow .vsix file creation and minor test name spelling fixes by CloudPlatformer · Pull Request #367 · Keyang/node-csvtojson · GitHub
[go: up one dir, main page]
Skip to content

Rename of test file to allow .vsix file creation and minor test name spelling fixes #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename of test file to allow .vsix file creation and minor test name spelling fixes #367

wants to merge 1 commit into from

Conversation

CloudPlatformer
Copy link

The below error occurs when creating a .vsix file for an Azure DevOps extension (https://docs.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#step-4-package-your-extension):

error: Error: Part Name 'task/node_modules/csvtojson/test/data/data#139' is invalid. Please check the following:
error: 1. No whitespace or any of these characters: #^[]<>?
error: 2. Cannot end with a period.
error: 3. No percent-encoded / or \ characters. Additionally, % must be followed by two hex characters.

Changes:

  1. Rename of data#139 file to dataWithUnquotedWhitespace to resolve .vsix file creation
  2. Minor spelling fixes of test file names
  3. Removal of commented out testCSVConverter.fork.ts

@Keyang Great module! Please review these changes.

@coveralls
Copy link
coveralls commented Feb 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 218

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 95.421%
Totals Coverage Status
Change from base Build 212: 0.06%
Covered Lines: 664
Relevant Lines: 680
💛 - Coveralls

@CloudPlatformer CloudPlatformer mentioned this pull request Feb 29, 2020
Merged
@CloudPlatformer
Copy link
Author

@jeremyrajan Could you please review this? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CloudPlatformer @coveralls
0