8000 Drop Python 3.7 from python_requires to fix 2.1.0 `SyntaxError` by tianweidut · Pull Request #118 · JoshData/python-email-validator · GitHub
[go: up one dir, main page]
Skip to content

Drop Python 3.7 from python_requires to fix 2.1.0 SyntaxError #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Drop Python 3.7 from python_requires to fix 2.1.0 SyntaxError #118

merged 1 commit into from
Oct 23, 2023

Conversation

tianweidut
Copy link
Contributor 
❯ conda activate py37
❯ python3
Python 3.7.16 (default, Jan 17 2023, 22:20:44) 
[GCC 11.2.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> exit
Use exit() or Ctrl-D (i.e. EOF) to exit
>>> exit()
❯ pip install email-validator
Looking in indexes: https://pypi.org/simple/, https://pypi.tuna.tsinghua.edu.cn/simple
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProtocolError('Connection aborted.', OSError(0, 'Error'))': /simple/email-validator/
Collecting email-validator
  Downloading https://pypi.tuna.tsinghua.edu.cn/packages/90/41/4767ff64e422734487a06384a66e62615b1f5cf9cf3b23295e22d3ecf711/email_validator-2.1.0-py3-none-any.whl (32 kB)
Collecting dnspython>=2.0.0
  Using cached https://pypi.tuna.tsinghua.edu.cn/packages/12/86/d305e87555430ff4630d729420d97dece3b16efcbf2b7d7e974d11b0d86c/dnspython-2.3.0-py3-none-any.whl (283 kB)
Requirement already satisfied: idna>=2.0.0 in ./anaconda3/envs/py37/lib/python3.7/site-packages (from email-validator) (3.4)
Installing collected packages: dnspython, email-validator
Successfully installed dnspython-2.3.0 email-validator-2.1.0
❯ python3
Python 3.7.16 (default, Jan 17 2023, 22:20:44) 
[GCC 11.2.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import email_validator
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tianwei/anaconda3/envs/py37/lib/python3.7/site-packages/email_validator/__init__.py", line 6, in <module>
    from .validate_email import validate_email
  File "/home/tianwei/anaconda3/envs/py37/lib/python3.7/site-packages/email_validator/validate_email.py", line 10
    /,  # prior arguments are positional-only
    ^
SyntaxError: invalid syntax
>>>

In python3.7 environment, 2.1.0 version can still be installed successfully.

8000
@tianweidut tianweidut changed the title Drop Python 3.7 install require to fix 2.1.0 SyntaxException Drop Python 3.7 install require to fix 2.1.0 SyntaxError Oct 23, 2023
@tianweidut tianweidut mentioned this pull request Oct 23, 2023
Merged
4 tasks
@tianweidut
Copy link
Contributor Author

@JoshData please review, thanks

@JoshData JoshData changed the title Drop Python 3.7 install require to fix 2.1.0 SyntaxError Drop Python 3.7 from python_requires to fix 2.1.0 SyntaxError Oct 23, 2023
@JoshData JoshData merged commit c3e8109 into JoshData:main Oct 23, 2023
@JoshData
Copy link
Owner

Thanks! I'll publish a new release.

@JoshData JoshData mentioned this pull request Oct 23, 2023
Closed
@tianweidut tianweidut deleted the patch-1 branch October 24, 2023 02:31
@JoshData JoshData mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @JoshData
0