8000 Add preCommitScript option by pikajude · Pull Request #945 · JamesIves/github-pages-deploy-action · GitHub
[go: up one dir, main page]
Skip to content

Add preCommitScript option #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add preCommitScript option #945

wants to merge 1 commit into from

Conversation

pikajude
Copy link
@pikajude pikajude commented Dec 7, 2021 •
edited
Loading

Description

Self-describing feature. Usecase: I'm using this action to deploy new versions of a specification I'm working on to a release branch. Old versions of the spec need to continuously be available so I deploy each new release to a subdirectory named after the release version.

The problem I ran into was the inability to generate a static HTML directory listing (using tree) before the new commit is made. I could do it with a github action whenever the release branch is updated, but that would be a pain, so I added this feature instead.

Testing Instructions

jest

@pikajude pikajude requested a review from JamesIves as a code owner December 7, 2021 22:37
@JamesIves
Copy link
Owner
JamesIves commented Dec 11, 2021 •
edited
Loading

Thanks for the contribution.

I'm curious about the use case of this vs just having an arbitrary script that runs before the deployment step.

      - name: pre-commit-script
        run: |
          # run some command here that modifies the "build" directory

      - name: Deploy 🚀
        uses: JamesIves/github-pages-deploy-action@4.1.7
        with: 
            folder: build

Are you specifically looking to modify the temporary deployment directory? If so couldn't you just make the changes you need to into the folder you plan to deploy and push that directly? We moved away from this approach since version 2 as ideally you shouldn't need to make any modifications once the folder has been generated.

For future changes/modifications do you mind creating a discussion or issue? That way it helps prioritize things and promotes discussion.

@JamesIves
Copy link
Owner

Closing as there's not much updates on this. Please start a discussion if you feel differently!

@JamesIves JamesIves closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesIves JamesIves Awaiting requested review from JamesIves JamesIves is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pikajude @JamesIves
0