8000 Make sure rm -rf actually works. by nomeata · Pull Request #242 · JamesIves/github-pages-deploy-action · GitHub
[go: up one dir, main page]
Skip to content

Make sure rm -rf actually works. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2020
Merged

Make sure rm -rf actually works. #242

merged 2 commits into from
Apr 9, 2020

Conversation

nomeata
Copy link
Contributor
@nomeata nomeata commented Apr 7, 2020

This makes sure directories in temporaryDeploymentDirectory are writabe before attempting to remove them. Fixes: #241

@nomeata
Make sure rm -rf actually works.
6c65dfb 
This makes sure directories in `temporaryDeploymentDirectory` are writabe before attempting to remove them. Fixes: JamesIves#241
@nomeata nomeata requested a review from JamesIves as a code owner April 7, 2020 15:39
JamesIves
JamesIves approved these changes Apr 8, 2020
View reviewed changes
Copy link
Owner
@JamesIves JamesIves left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomeata Looks good! Could you run the format / lint/ test commands? It looks like the unit-tests job is failing.

@JamesIves JamesIves self-requested a review April 8, 2020 13:32
@nomeata
Copy link
Contributor Author
nomeata commented Apr 8, 2020

I edited the file via github I didn't even checkout.

I’m surprised there is no github action here that does code formatting ;-)

@nomeata
Copy link
Contributor Author
nomeata commented Apr 8, 2020

How do I run these command? CONTRIBUTING.md doesn’t tell me, and I don't know the build system you are using here.

Ok, figured it out

@nomeata
Copy link
Contributor Author
nomeata commented Apr 8, 2020

Sorry, I don’t understand the test failure

@JamesIves JamesIves added this to the 3.4.7 milestone Apr 8, 2020
@JamesIves JamesIves merged commit 42b6247 into JamesIves:dev Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesIves JamesIves Awaiting requested review from JamesIves JamesIves is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.7
Development

Successfully merging this pull request may close these issues.

The process '/bin/rm' failed with exit code 1
2 participants
@nomeata @JamesIves
0