8000 append commit SHA to commit msg, only if not a part of it already. by lycuid · Pull Request #236 · JamesIves/github-pages-deploy-action · GitHub
[go: up one dir, main page]
Skip to content

append commit SHA to commit msg, only if not a part of it already. #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2020
Merged

append commit SHA to commit msg, only if not a part of it already. #236

merged 4 commits into from
Apr 4, 2020

Conversation

lycuid
Copy link
Contributor
@lycuid lycuid commented Apr 3, 2020

problem: user provided commit message being modified (appending the commit SHA).
As the user, it is a bit annoying to have the commit SHA appear twice in the commit message.

possible solutions:

  • do not append the commit SHA, if user has already included it the commit message.
  • let the user decide whether the user's commit message can be modified. (maybe via argument in action.yml).

@lycuid lycuid requested a review from JamesIves as a code owner April 3, 2020 15:38
@JamesIves
Copy link
Owner

I wasn't aware you could pass in the commit SHA into an action arg. As that's the case we should probably make it so the commit message totally overrides the default one if it's specified instead of having logic that excludes it only if it's included.

@lycuid
Copy link
Contributor Author
lycuid commented Apr 3, 2020

Yeah, that's the better option, the appended SHA is kinda redundant.

JamesIves
JamesIves reviewed Apr 3, 2020
View reviewed changes
lycuid and others added 2 commits April 4, 2020 01:39
@lycuid @JamesIves
Update src/git.ts
2da2e22 
check, if SHA exists, before appending to commit message.

Co-Authored-By: James Ives <iam@jamesiv.es>
@lycuid
linting bug fix (from failed workflow).
56e1379
@codecov-io
Copy link

Codecov Report

Merging #236 into dev will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          161       161           
  Branches        41        41           
=========================================
  Hits           161       161
Impacted Files Coverage Δ
src/git.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7308b6d...56e1379. Read the comment docs.

JamesIves
JamesIves approved these changes Apr 3, 2020
View reviewed changes
Copy link
Owner
@JamesIves JamesIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will go out as part of the next update this weekend.

@JamesIves JamesIves merged commit 145d802 into JamesIves:dev Apr 4, 2020
@JamesIves JamesIves added this to the 3.4.7 milestone Apr 9, 2020
@JamesIves
Copy link
Owner

Released as part of 3.4.7: https://github.com/JamesIves/github-pages-deploy-action/releases/tag/3.4.7

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesIves JamesIves JamesIves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lycuid @JamesIves @codecov-io
0