random pad input ids #3530
Merged
random pad input ids #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
May 9, 2025
| @@ -1675,7 +1675,7 @@ def build_qkv_proj(in_features: int, | |||
| device: Optional[torch.device] = None, | |||
| is_tp: bool = True, | |||
| num_replicate_kv_heads: int = 1, | |||
| dp_disable_tp: bool = False, | |||
| dp_disable_tp: bool = True, | |||
There was a problem hiding this comment.
this is a fix for dp+tp.
lvhan028
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero-padded input ids would lead to an imbalance in expert selection.
Fix dp-tp attention default behaviour.