8000 Fixes pack of failed tests by kozlov-alexey · Pull Request #974 · IntelPython/sdc · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Fixes pack of failed tests #974

Merged
merged 2 commits into from
May 11, 2021
Merged

Fixes pack of failed tests #974

merged 2 commits into from
May 11, 2021

Conversation

kozlov-alexey
Copy link
Contributor

Motivation: as title.

@pep8speaks
Copy link
pep8speaks commented May 5, 2021 •
edited
Loading

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-06 17:37:37 UTC

@kozlov-alexey kozlov-alexey force-pushed the bugfix/fix_failed_tests branch from 584d396 to 4991be3 Compare May 5, 2021 02:27
@Hardcode84
Copy link
Contributor

Skipping floordiv test due to diff behavior in Stock vs Intel numpy

This is probably a real bug either on our side or on intel Numpy/mkl side. Better to report this to mkl team

@kozlov-alexey kozlov-alexey added this to the 0.39 milestone May 5, 2021
@kozlov-alexey kozlov-alexey force-pushed the bugfix/fix_failed_tests branch from 4abb0da to 59e8a0b Compare May 6, 2021 17:37
@kozlov-alexey
Copy link
Contributor Author

Skipping floordiv test due to diff behavior in Stock vs Intel numpy

This is probably a real bug either on our side or on intel Numpy/mkl side. Better to report this to mkl team

I created SAT-4111 for tracking it. Also it seems like these unexpected successes of this test in azure pipeline were caused by move from numpy=1.19 to numpy=1.20, where (see numpy/numpy#16161) floordiv behavior was changed.

@kozlov-alexey
Copy link
Contributor Author

Merging this to unblock CI (fails in python 3.8 checks are investigated by Infra team).

@kozlov-alexey kozlov-alexey merged commit 18cf6ae into IntelPython:master May 11, 2021
kozlov-alexey added a commit to kozlov-alexey/sdc that referenced this pull request May 11, 2021
@kozlov-alexey
Fixes pack of failed tests (IntelPython#974)
676246f 
* Fixes pack of failed tests

* Skipping floordiv test due to diff behavior in Stock vs Intel numpy
kozlov-alexey added a commit that referenced this pull request May 21, 2021
@kozlov-alexey
Remove hardcoded dependencies from install instruction (#969)
f9dd4d7 
* Remove hardcoded dependencies from install instruction

Motivation: installation instruction is often updated at the same time
when SDC moves to new version of dependencies, and while building SDC
from source works, installing from pre-built binaries might fail since
package is uploaded to intel/label/beta only after all validation
checks.

* Verify install steps in azure CI

* Fixing PEP

* Fixes pack of failed tests (#974)

* Fixes pack of failed tests

* Skipping floordiv test due to diff behavior in Stock vs Intel numpy

* Fixing bugs test_conda_install run
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hardcode84 Hardcode84 Hardcode84 approved these changes

@AlexanderKalistratov AlexanderKalistratov AlexanderKalistratov approved these changes

@Alexander-Makaryev Alexander-Makaryev Awaiting requested review from Alexander-Makaryev

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
0.39
Development

Successfully merging this pull request may close these issues.
4 participants
@kozlov-alexey @pep8speaks @Hardcode84 @AlexanderKalistratov
0