8000 Update to Numba 0.49.1 by PokhodenkoSA · Pull Request #838 · IntelPython/sdc · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Update to Numba 0.49.1 #838

Merged
merged 3 commits into from
May 14, 2020
Merged

Update to Numba 0.49.1 #838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
683bf58
Update to Numba 0.49.1
PokhodenkoSA May 14, 2020
93052d4
Fix requirements.txt
PokhodenkoSA May 14, 2020
35040be
Merge branch 'master' into update/numba-0.49.1
PokhodenkoSA May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update to Numba 0.49.1
  • Loading branch information
@PokhodenkoSA
PokhodenkoSA committed May 14, 2020
commit 683bf58ed39cf16e4334b70e2c4846fb2378a23a
10 changes: 2 additions & 8 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ the code by leveraging modern hardware instructions and by utilizing all availab

Intel® SDC documentation can be found `here <https://intelpython.github.io/sdc-doc/>`_.

Intel® SDC uses special Numba build based on ``0.48.0`` tag for build and run.
Required Numba version can be installed from ``intel/label/beta`` channel from the Anaconda Cloud.

.. note::
For maximum performance and stability, please use numba from ``intel/label/beta`` channel.

Expand Down Expand Up @@ -61,9 +58,6 @@ If you do not have conda, we recommend using Miniconda3::
./miniconda.sh -b
export PATH=$HOME/miniconda3/bin:$PATH

Intel® SDC uses special Numba build based on ``0.48.0`` tag for build and run.
Required Numba version can be installed from ``intel/label/beta`` channel from the Anaconda Cloud.

.. note::
For maximum performance and stability, please use numba from ``intel/label/beta`` channel.

Expand All @@ -88,7 +82,7 @@ Building on Linux with setuptools

PYVER=<3.6 or 3.7>
NUMPYVER=<1.16 or 1.17>
conda create -n sdc-env -q -y -c intel/label/beta -c defaults -c intel -c conda-forge python=$PYVER numpy=$NUMPYVER numba=0.48.0 pandas=0.25.3 pyarrow=0.15.1 gcc_linux-64 gxx_linux-64
conda create -n sdc-env -q -y -c intel/label/beta -c defaults -c intel -c conda-forge python=$PYVER numpy=$NUMPYVER numba=0.49 pandas=0.25.3 pyarrow=0.15.1 gcc_linux-64 gxx_linux-64
source activate sdc-env
git clone https://github.com/IntelPython/sdc.git
cd sdc
Expand Down Expand Up @@ -126,7 +120,7 @@ Building on Windows with setuptools

set PYVER=<3.6 or 3.7>
set NUMPYVER=<1.16 or 1.17>
conda create -n sdc-env -c intel/label/beta -c defaults -c intel -c conda-forge python=%PYVER% numpy=%NUMPYVER% numba=0.48.0 pandas=0.25.3 pyarrow=0.15.1
conda create -n sdc-env -c intel/label/beta -c defaults -c intel -c conda-forge python=%PYVER% numpy=%NUMPYVER% numba=0.49 pandas=0.25.3 pyarrow=0.15.1
conda activate sdc-env
set INCLUDE=%INCLUDE%;%CONDA_PREFIX%\Library\include
set LIB=%LIB%;%CONDA_PREFIX%\Library\lib
Expand Down
2 changes: 1 addition & 1 deletion buildscripts/sdc-conda-recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% set NUMBA_VERSION = "==0.49.0" %}
{% set NUMBA_VERSION = "==0.49.1" %}
{% set PANDAS_VERSION = "==0.25.3" %}
{% set PYARROW_VERSION = "==0.15.1" %}

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def run(self):
'numpy>=1.16',
'pandas==0.25.3',
'pyarrow==0.15.1',
'numba>=0.48'
'numba >=0.49.0,<0.50.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be display 10000 ed to describe this comment to others. Learn more.

Why not 0.49.1?

Copy link
Contributor Author
@PokhodenkoSA PokhodenkoSA May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For not be bound to 0.49.1 when 0.49.2 will be released.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then probably it would be better > 0.49.0 ?

Copy link
Contributor Author
@PokhodenkoSA PokhodenkoSA May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 0.50.0 could break backward compatibility.

Copy link
Collaborator
@AlexanderKalistratov AlexanderKalistratov May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> 0.49.0, <0.50.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But 0.49.0 is also workable.

Copy link
Contributor Author
@PokhodenkoSA PokhodenkoSA May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong. Numba 0.49.0 has significant regressions, it is better not to use it and start from 0.49.1.

],
cmdclass=sdc_build_commands,
ext_modules=_ext_mods,
Expand Down
0