8000 Backprt gh-2467 by antonwolfy · Pull Request #2468 · IntelPython/dpnp · GitHub
[go: up one dir, main page]
Skip to content

Backprt gh-2467 #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Backprt gh-2467 #2468

merged 1 commit into from
Jun 3, 2025

Conversation

antonwolfy
Copy link
Contributor
@antonwolfy antonwolfy commented Jun 3, 2025 •
edited
Loading

This PR backports of #2467 from development branch to maintenance/0.18.x.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy
Use hasattr instead of getattr in checks for convert_item call (#…
3155396 
…2467)

The PR improves tests logic to replace unnecessary `getattr` with
`hasattr` call to check an item interface.
@antonwolfy antonwolfy self-assigned this Jun 3, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 3, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit fc8174f into maintenance/0.18.x Jun 3, 2025
54 of 59 checks passed
@antonwolfy antonwolfy deleted the backport-gh-2467 branch June 3, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana
0