10000 Bump `target-version` in black configuration by antonwolfy · Pull Request #2457 · IntelPython/dpnp · GitHub
[go: up one dir, main page]
Skip to content

Bump target-version in black configuration #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

Bump target-version in black configuration #2457

merged 3 commits into from
May 19, 2025

Conversation

antonwolfy
Copy link
Contributor
@antonwolfy antonwolfy commented May 19, 2025 •
edited
Loading

The PR updates configuration of black tool to align target-version with the list of supported python versions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this May 19, 2025
@antonwolfy antonwolfy added this to the 0.18.0 release milestone May 19, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 19, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev3=py312he4f9c94_5 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.757%. remained the same
when pulling d2ad97a on bump-black-target-versions
into 5ba16f4 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator
@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

vtavana
vtavana approved these changes May 19, 2025
View reviewed changes
pyproject.toml
@@ -1,6 +1,6 @@
[tool.black]
line-length = 80
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy (Python, C/C++) and SciPy and a few other project have switched to line-length=88.
Just noting it here in case we want to consider it in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I think we can follow the same approach by the separate PR.

@antonwolfy antonwolfy merged commit 55deb00 into master May 19, 2025
58 of 68 checks passed
@antonwolfy antonwolfy deleted the bump-black-target-versions branch May 19, 2025 14:53
github-actions bot added a commit that referenced this pull request May 19, 2025
@github-actions
Bump target-version in black configuration (#2457)
ff6e88b 
The PR updates configuration of `black` tool to align `target-version`
with the list of supported python versions. 55deb00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
4 participants
@antonwolfy @coveralls @vlad-perevezentsev @vtavana
0