8000 fix issue 424 by PhilCai1993 · Pull Request #426 · Instagram/IGListKit · GitHub
[go: up one dir, main page]
Skip to content

fix issue 424 #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PhilCai1993 wants to merge 1 commit into from
Closed

fix issue 424 #426

PhilCai1993 wants to merge 1 commit into from

Conversation

@PhilCai1993
Copy link
Contributor
@Phi 8000 lCai1993 PhilCai1993 commented Jan 18, 2017 •
edited by jessesquires
Loading

Changes in this pull request

Fixes #424

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jan 18, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jan 18, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor
facebook-github-bot commented Jan 18, 2017

@PhilCai1993 updated the pull request - view changes

@PhilCai1993 PhilCai1993 mentioned this pull request Jan 18, 2017
Closed
@PhilCai1993
Copy link
Contributor Author
PhilCai1993 commented Jan 18, 2017

Fixed #424

@coveralls
Copy link
coveralls commented Jan 18, 2017

Coverage Status

Coverage remained the same at 98.064% when pulling 1dfbc5e on PhilCai1993:fix_issue424 into 8d74b8f on Instagram:master.

2 similar comments
@coveralls
Copy link
coveralls commented Jan 18, 2017

Coverage Status

Coverage remained the same at 98.064% when pulling 1dfbc5e on PhilCai1993:fix_issue424 into 8d74b8f on Instagram:master.

@coveralls
Copy link
coveralls commented Jan 18, 2017

Coverage Status

Coverage remained the same at 98.064% when pulling 1dfbc5e on PhilCai1993:fix_issue424 into 8d74b8f on Instagram:master.

@coveralls
Copy link
coveralls commented Jan 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.064% when pulling 1dfbc5e on PhilCai1993:fix_issue424 into 8d74b8f on Instagram:master.

@jessesquires jessesquires added this to the 2.2.0 milestone Jan 18, 2017
jessesquires pushed a commit that referenced this pull request Jan 18, 2017
@PhilCai1993 @jessesquires
fix issue 424
6522d72 
Summary:
- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes #426

Differential Revision: D4428853

Pulled By: rnystrom

fbshipit-source-id: 1c5f3aa196a726986be291c7347eded853eb0eac
@PhilCai1993 PhilCai1993 deleted the fix_issue424 branch January 19, 2017 02:25
@PhilCai1993 PhilCai1993 restored the fix_issue424 branch January 19, 2017 02:26
@jessesquires jessesquires modified the milestones: 2.2.0, 3.0.0 Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Is it right to use OBJC_ASSOCIATION_ASSIGN?

4 participants

@PhilCai1993 @facebook-github-bot @coveralls @jessesquires
0