8000 Clean up of dependencies · Issue #4368 · IfcOpenShell/IfcOpenShell · GitHub
[go: up one dir, main page]
Skip to content

Clean up of dependencies #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Moult opened this issue Feb 27, 2024 · 5 comments
Closed

Clean up of dependencies #4368

Moult opened this issue Feb 27, 2024 · 5 comments
Labels
Bonsai

Comments

@Moult
Copy link
Contributor
Moult commented Feb 27, 2024 •
edited
Loading

So, uh, apparently you can't do something like pip install --no-tests foo :( https://stackoverflow.com/questions/54743853/installing-a-package-without-including-test-code

Uncompressed, the tests dir for pandas is 35MB (!!!) pandas-dev/pandas#30741

There are a number of dependencies which need cleaning up for a leaner, faster download and install for users. Our libs/site/packages folder on Windows is 367MB uncompressed. Yikes!

  • Manually purge test files especially for Pandas if no alternative exists.
  • Question whether Augin is still needed. It's generally unmaintained and not sure if it has any real benefit to people using it. The AWS Botocore library is 55MB uncompressed!
  • Ping @gtfierro about whether Brickschema can be pared down a bit. topquadrant_shacl is 48MB uncompressed and ontologies v1.1 and v1.2 are shipped (are they necessary? We actually grab a nightly Brick.ttl) SQLAlchemy is 18.9MB. Abstraction is nice, but ... surprisingly heavy in this case - I think only sqlite is used after all.
  • Remove hppfcl et friends as part of the new clash features.
  • Don't ship all express rules for IfcOpenShell, only ISO standards.
  • Question whether or not we should still maintain and support BIMTester + Behave et friends. As IDS matures it is increasingly a niche tool.
@Moult Moult added the Bonsai label Feb 27, 2024
@gtfierro
Copy link
gtfierro commented Mar 5, 2024

@Moult please try out brickschema==0.7.6a1 version, for which the topquadrant SHACL stuff is an optional package. Not sure what I could do about SQLAlchemy's size. I'll look into compressing the older ontologies too
8000

Moult added a commit that referenced this issue Mar 6, 2024
@Moult
See #4368. Don't ship with mostly unused and bloaty boto3 dep. Augin …
20cb6ab 
…users can install boto3 with new debug tool.
@Moult
Copy link
Contributor Author
Moult commented Mar 6, 2024 •
edited
Loading

@gtfierro oh sorry I think there was a miscommunication, it's about this topquadrant folder.

Edit: I see you removed it yet I still see it in the PyPI build for 0.7.6a1?

@gtfierro
Copy link
gtfierro commented Mar 6, 2024

Strange! I definitely meant to remove it. I'll take a look soon

@gtfierro
Copy link
gtfierro commented Mar 6, 2024

Please try 0.7.6a2! I forgot to remove the jar files from the actual repository

@Moult
Copy link
Contributor Author
Moult commented Mar 29, 2024

Nice!

$ pip install "brickschema[persistence]==0.7.6a1" --target foo/
$ pip install "brickschema[persistence]==0.7.6a2" --target bar/
$ du -sh foo
104M    foo
$ du -sh bar
56M     bar

Thanks so much!

@Moult Moult closed this as completed in 84dcee6 Mar 29, 2024
aothms pushed a commit that referenced this issue Apr 18, 2024
@Moult
See #4368. Don't ship with mostly unused and bloaty boto3 dep. Augin …
7b3b32c 
…users can install boto3 with new debug tool.
aothms pushed a commit that referenced this issue Apr 18, 2024
@Moult
Fix #4368. Update to latest Brickschema alpha to cut dep size
9487996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bonsai
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtfierro @Moult
0