Course pinning, search and filter feature in user's course list#1084
Open
AlexandreDoneux wants to merge 18 commits intoINGInious:mainfrom
Open
Course pinning, search and filter feature in user's course list#1084AlexandreDoneux wants to merge 18 commits intoINGInious:mainfrom
AlexandreDoneux wants to merge 18 commits intoINGInious:mainfrom
Conversation
ca80065 to
3629b1f
Compare
anthonygego
reviewed
Oct 31, 2025
anthonygego
reviewed
Oct 31, 2025
anthonygego
reviewed
Oct 31, 2025
… by using tabs in UI
4acd1cc to
d2963cc
Compare
AlexandreDoneux
commented
Dec 10, 2025
anthonygego
requested changes
Dec 12, 2025
Member
|
BTW take a look at the Codacy report, there are many JS issues reported such as the usage of |
34ced92 to
9bc8b71
Compare
anthonygego
requested changes
Mar 9, 2026
Member
There was a problem hiding this comment.
I would not include the descriptions in the pinned cards, and rather use the internal link for the course as this is the case for the full list in this view.
Otherwise just cosmetic and more idiomatic suggestions.
| $(document).find("#no_pin_message").addClass("d-none"); | ||
| } | ||
|
|
||
| } else { // unpinning |
Member
There was a problem hiding this comment.
Maybe we can provide an upin icon from the pinned card too. This would allow to remove a pinned course without going to the possibly long list of courses.
Comment on lines
+106
to
+111
| if (filter_value === "true" && !$item.hasClass(filter_id)) { | ||
| visible = false; | ||
| } | ||
| if (filter_value === "false" && $item.hasClass(filter_id)) { | ||
| visible = false; | ||
| } |
Member
There was a problem hiding this comment.
Would this be equivalent ?
Suggested change
| if (filter_value === "true" && !$item.hasClass(filter_id)) { | |
| visible = false; | |
| } | |
| if (filter_value === "false" && $item.hasClass(filter_id)) { | |
| visible = false; | |
| } | |
| if (!$item.hasClass(filter_id)) { | |
| visible = !(filter_value === "true" || filter_value === "false"); | |
| } |
Comment on lines
+123
to
+125
|
|
||
|
|
||
|
|
Member
There was a problem hiding this comment.
You can remove those spaces :-)
Comment on lines
+659
to
+666
| data = User.objects(username=username).first() | ||
| if data: | ||
| pinned_courses = data.pinned_courses if data else [] | ||
| if courseid not in pinned_courses: | ||
| pinned_courses.append(courseid) | ||
| User.objects(username=username).update(pinned_courses=pinned_courses) | ||
| return True | ||
| return False |
Member
There was a problem hiding this comment.
I think you can do this more effenciently using the $addToSet MongoDB operator, as you did for the unpin_course method and the $pull operator.
Suggested change
| data = User.objects(username=username).first() | |
| if data: | |
| pinned_courses = data.pinned_courses if data else [] | |
| if courseid not in pinned_courses: | |
| pinned_courses.append(courseid) | |
| User.objects(username=username).update(pinned_courses=pinned_courses) | |
| return True | |
| return False | |
| modified = User.objects(username=username).update(add_to_set__pinned_courses=courseid) | |
| return modified is not None |
anthonygego
reviewed
Mar 10, 2026
| '../../frontend/static/js/groups.js', | ||
| '../../frontend/static/js/checked-list-group.js', | ||
| '../../frontend/static/js/task_dispensers.js', | ||
| '../../frontend/static/js/admin.js', |
Member
There was a problem hiding this comment.
Suggested change
| '../../frontend/static/js/admin.js', | |
| '../../frontend/static/js/mycourses.js' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the user experience regarding the user's course list. Currently displayed as a basic list, it can get difficult to find a specific course if you manage a lot of them. This PR brings multiple ways to improve this list :
This PR is based on the #1077 PR. Therefore it will stay as draft until those changes are accepted.