Remove now-incorrect numpy assertion #4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
approved these changes
Sep 12, 2024
Comment on lines
1306
to
1308
| # Two args: ndarray[shape, type], NDArray[*] | ||
| assert len(args) == 2 | ||
| assert args[0] is Any | ||
| dtype = _unpack_dtype(args[1]) |
There was a problem hiding this comment.
Just checking, we still expect the dtype type to be the second element here?
There was a problem hiding this comment.
yup, though I had to go find the pr numpy-side to convince myself of this: numpy/numpy#27211
11207ef to
a902288
Compare
a902288 to
6dfe346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed on numpy nightlies: closes #4102.
This is in
src/, so actual users will start hitting this once the numpy nightly becomes not nightly.(possibly this was the root cause of the other #4102 errors, we'll see what ci says.)