Add gaussdb_skip markers and adjust connection pool tests for GaussDB #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
/div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Add gaussdb_skip markers and adjust connection pool tests for GaussDB
PR Description
Description
This PR enhances test compatibility for GaussDB by adding
gaussdb_skipmarkers to test cases that rely on unsupported features, such as backend PID andpg_terminate_backend. It also adjusts timeouts, tolerances, and schema definitions to ensure stable test execution in GaussDB environments.Changes Made
gaussdb_skipmarkers to multiple test cases, including:test_broken_reconnect,test_queue_timeout,test_stats_measures,test_check_connection,test_active_close,test_reset_broken,test_max_lifetime,test_intrans_rollback,test_fail_rollback_close,test_reset_badstate,test_check_max_lifetime,test_connect_check,test_connect_no_check,test_stats_check,test_getconn_check, andtest_its_no_pool_at_all, due to unsupported backend PID orpg_terminate_backend.requests_wait_msandusage_msdelays to align with GaussDB behavior.requests_errorsexpectation to1in relevant tests.CREATE TABLEstatement intest_intrans_rollbackfor GaussDB compatibility.Why
GaussDB does not support certain PostgreSQL features, such as
backend PIDandpg_terminate_backend, causing test failures. Skipping these tests ensures the test suite runs successfully on GaussDB. Timeout and schema adjustments were necessary to accommodate GaussDB’s connection pooling and performance characteristics.Testing
test_intrans_rollbackto confirm compatibility with GaussDB.Additional Notes
gaussdb_skipmarkers for each test case.test_intrans_rollbackaligns with GaussDB requirements.