8000 Enhance Test and CI Compatibility with openGauss by pangpang20 · Pull Request #10 · HuaweiCloudDeveloper/gaussdb-python · GitHub
[go: up one dir, main page]
Skip to content

Enhance Test and CI Compatibility with openGauss #10

New issue
< 8000 div class="mt-3 mb-2 text-center">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 10, 2025
Merged

Enhance Test and CI Compatibility with openGauss #10

merged 29 commits into from
Jun 10, 2025

Conversation

pangpang20
Copy link

escription

This PR introduces comprehensive support and adjustments for running the test suite against openGauss, including enhanced compatibility, test skipping for unsupported features, and improved CI configuration.

Changes Made

General Improvements

  • Added try-finally blocks to ensure proper cursor and resource cleanup.
  • Introduced database type detection to dynamically skip unsupported tests.
  • Added @pytest.mark.opengauss_skip marker for granular control over test execution.

Test Suite Adjustments for openGauss

  • Skipped or marked the following tests as unsupported on openGauss:
    • Binary COPY tests for types like inet, cidr, json, datetime, etc.
    • String encoding tests due to binary copy incompatibilities.
    • test_error_encoding (unsupported DO blocks).
    • Connection and async pool tests (no backend PID or pg_terminate_backend support).
    • Reconnect tests (due to backend PID handling differences).
    • SERIALIZABLE isolation level and session timeout behavior.
    • PGconn.info tests due to format discrepancies.

CI Workflow Enhancements

  • Added new GitHub Actions CI job targeting GaussDB (openGauss).
  • Replaced secret-based password with a randomly generated secure password using Python.
  • Standardized DB username to root for consistency with container defaults.
  • Enabled pre-commit linting and installed types-polib.
  • Added Python 3.11 to lint jobs and integrated async/sync compatibility check.

Why

openGauss is not fully PostgreSQL-compatible. These changes ensure:

  • Incompatible tests do not fail CI and are documented as skipped.
  • CI runs reliably on both PostgreSQL and openGauss.
  • Code quality remains high with proper linting and async validation.

Testing

  • All tests passing on GitHub Actions using openGauss.
  • Incompatible tests correctly skipped with justification.
  • Linting and static type checks passing using pre-commit.

Additional Notes

  • This PR does not affect production code.
  • All modifications are limited to tests, tooling, and CI configuration.
  • Skipped tests may be re-enabled in the future if openGauss expands support.

pangpang20 added 29 commits June 6, 2025 15:21
@pangpang20
Add try-finally block to ensure proper cursor closure
e99262b
@pangpang20
Add support for opengauss_skip marker in pytest_collection_modifyitems
f72ab70
@pangpang20
Add database type detection and skip tests based on DB type
1de855a
@pangpang20
Mark binary copy read tests as unsupported on openGauss and fix line …
9d0ec90 
…length
@pangpang20
Mark binary copy read tests as unsupported on openGauss and fix line …
cf0c966 
…length
@pangpang20
Skip nested array test for openGauss
4f0e0a1
@pangpang20
Skip string encoding tests on openGauss due to binary copy incompatib…
155a9d0 
…ility
@pangpang20
Skip JSON copy test on openGauss due to binary copy signature mismatch
772f1a0
@pangpang20
Skip inet/cidr binary copy tests on openGauss due to signature mismatch
2a6c22e
@pangpang20
Skip datetime tests on openGauss due to timestamp/year and copy limit…
f4b507d 
…ations
@pangpang20
Skip binary COPY test on openGauss due to incompatible output format
689ac22
@pangpang20
Skip test_server_version on openGauss due to version format incompati…
36d4af2 
…bility
@pangpang20
Skip test_error_encoding on openGauss due to unsupported DO blocks
1cf4eb3
@pangpang20
Skip connection pool tests on openGauss due to lack of backend PID an…
d3a28b4 
…d pg_terminate_backend support
@pangpang20
Skip async pool tests on openGauss due to missing backend PID and pg_…
34e61b2 
…terminate_backend support
@pangpang20
Skip broken_reconnect test on openGauss due to missing backend PID su…
815d8a7 
…pport
@pangpang20
Skip broken_reconnect async test on openGauss due to missing backend …
8d80a3a 
…PID support
@pangpang20
Skip backend pid tests on openGauss
460e5f6
@pangpang20
Skip backend pid tests on openGauss
230e16f
@pangpang20
Skip unsupported SERIALIZABLE level and session timeout on openGauss
d0e387e
@pangpang20
Skip PGconn.info tests on openGauss
8e64fe2
@pangpang20
Add CI workflow and requirements
e883197
@pangpang20
Address code style issues and enhance GaussDB compatibility
f1eb572
@pangpang20
Switch to Python 3.9 and disable workflow on push events
346b001
@pangpang20
Re-enable lint workflow on push events
3bf61e4
@pangpang20
Add types-polib to lint workflow dependencies
d488b27
@pangpang20
Enable async test compatibility and relax timing assertion tolerance
0af8c17
@pangpang20
Add Python 3.11 to lint workflow and check sync/async compatibility
0d47065
@pangpang20
Update CI workflow to use fixed database username root
12b8048
@5xuanwen 5xuanwen merged commit 92aaa40 into HuaweiCloudDeveloper:master Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pangpang20 @5xuanwen
0