Remove OpenSSL provider from Botan formula #57540
Conversation
Formula/botan.rb
Outdated
| @@ -14,7 +14,7 @@ class Botan < Formula | |||
|
|
|||
| depends_on "pkg-config" => :build | |||
| depends_on :macos # Due to Python 2 | |||
There was a problem hiding this comment.
Is this still true? The configure script suggests it should work with python 3.
There was a problem hiding this comment.
Upstream maintainer here. The configure script absolutely works with Python3 (we are maintaining 2+3 compat for the time being, though will eventually move to Python3 only)
There was a problem hiding this comment.
@securitykernel could you amend your PR to make it use python@3.8 then instead of depending on macOS?
There was a problem hiding this comment.
Did that.
There was a problem hiding this comment.
You might need to set the python version cause it's installing python 2.7 bindings right now.
There was a problem hiding this comment.
I see. Updated.
There was a problem hiding this comment.
@SMillerDev Rebased onto master (2.15.0 version bump). Ready for merge IMHO.
46343a8 to
c503093
Compare
|
LGTM, @securitykernel could you please rename your commit to say |
c503093 to
22f900c
Compare
|
@SMillerDev Renamed the commit. |
There was a problem hiding this comment.
Thanks @securitykernel ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
|
🤖 A scheduled task has triggered a merge. |
The authors do not recommend building with
OpenSSL support. Additionally, they recommend
building with sqlite support.
See https://botan.randombit.net/handbook/packaging.html.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?