netperf: Enable Demo mode #25503
Closed
netperf: Enable Demo mode #25503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables demo mode for netperf, which is useful for running tests that need to look at the bandwidth changing over time. Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
|
Hi @tohojo, thanks for the pull request! We'll decline, as we avoid patches as much as possible — we typically only add patches when build is broken or crucial functionality is missing. |
|
Well, this is an attempt to fix a broken build, so to speak. I am the author of a test tool that uses netperf but requires --demo-mode to work. The patch is required to build with that enabled.
As an alternative, I can create a pull request that changes netperf to build from git instead?
|
|
To build from the latest git you can already do |
|
FX Coudert <notifications@github.com> writes:
To build from the latest git you can already do `brew install --HEAD
netperf`
Yes, but that doesn't get me the --enable-demo to configure. Which is
the point of this pull request :)
What is an acceptable way of getting this enabled by default? It is
quite useful to have and I'm trying to avoid having to explain to people
that they need to edit the brew formula...
|
|
|
Right. I'll see if I can get the netperf devs to tag a new release... Thanks :)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables demo mode for netperf, which is useful for running tests that
need to look at the bandwidth changing over time.
Signed-off-by: Toke Høiland-Jørgensen toke@toke.dk
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?