8000 systemc: Switch to autotools configure by FlyGoat · Pull Request #225258 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]

Skip to content

systemc: Switch to autotools configure #225258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

FlyGoat
Copy link
Contributor
@FlyGoat FlyGoat commented May 30, 2025

systemc's cmake build lacks many features, namely
pkg-config files and document & example files.

Fix by switching to autotools configure based build flow, also applying patch from Debian to fix document build.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333
Copy link
Member

the cmake switch was due to the fact that autotools build did not work before, accellera-official/systemc#40

@chenrui333
Copy link
Member

systemc's cmake build lacks many features, namely
pkg-config files and document & example files.

any issue tracking it?

@FlyGoat
Copy link
Contributor Author
FlyGoat commented May 30, 2025

systemc's cmake build lacks many features, namely
pkg-config files and document & example files.

any issue tracking it?

pkg-config and so on is marked as TODO in cmake file:
https://github.com/accellera-official/systemc/blob/e7d46b0ff762f842cfea459d8f22dd18fa7acd0f/CMakeLists.txt#L164

Other distros like Debian and Fedora are all using autotools.

@chenrui333
Copy link
Member

systemc's cmake build lacks many features, namely
pkg-config files and document & example files.

any issue tracking it?

pkg-config and so on is marked as TODO in cmake file: https://github.com/accellera-official/systemc/blob/e7d46b0ff762f842cfea459d8f22dd18fa7acd0f/CMakeLists.txt#L164

Other distros like Debian and Fedora are all using autotools.

make sense 👍

@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label May 30, 2025
systemc's cmake build lacks many features, namely
pkg-config files and document & example files.

Fix by switching to autotools configure based build
flow, also applying patch from Debian to fix document
build.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
@FlyGoat FlyGoat force-pushed the systemc-autotools branch from ee0f0f0 to 37a7ed7 Compare May 30, 2025 20:23
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label May 30, 2025
@chenrui333
Copy link
Member

@FlyGoat, thanks for your first contribution to homebrew-core! 🎉 💯

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 30, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 30, 2025 20:59
@BrewTestBot BrewTestBot added this pull request to the merge queue May 30, 2025
Merged via the queue into Homebrew:master with commit 1b9290d May 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0