8000 qt: Fix build errors on macOS 12 Monterey by samumbach · Pull Request #225241 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

qt: Fix build errors on macOS 12 Monterey #225241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qt: Fix build errors on macOS 12 Monterey #225241

wants to merge 1 commit into from

Conversation

samumbach
Copy link
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See also #223426.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. nodejs Node or npm use is a significant feature of the PR or issue CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels May 30, 2025
@samumbach samumbach mentioned this pull request May 30, 2025
Closed
6 tasks
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label May 30, 2025
@samumbach
qt: resolve build error on macOS 12 Monterey: Qt requires at least ve…
335be3f 
…rsion 14 of the platform SDK, you're building against version 13.1.
@samumbach samumbach force-pushed the fix-build-errors-on-macOS-12-monterey-qt branch from f58caa0 to 335be3f Compare June 4, 2025 13:57
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 4, 2025
chenrui333
chenrui333 reviewed Jun 24, 2025
View reviewed changes
Formula/q/qt.rb
@@ -42,6 +42,7 @@ class Qt < Formula
depends_on xcode: :build

depends_on "assimp"
depends_on "at-spi2-core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why making this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 I received the following errors when attempting to compile qt on macOS 12 Monterey. They were resolved by adding the at-spi2-core dependency.

...
==> cmake --build build
...
FAILED: qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/atspiadaptor.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DENABLE_PIXMAN_DRAWHELPERS -DGL_SILENCE_DEPRECATION -DGui_EXPORTS -DQT_ASCII_CAST_WARNINGS -DQT_BUILDING_QT -DQT_BUILD_GUI_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS -DQT_EXPLICIT_QFILE_CONSTRUCTION_FROM_PATH -DQT_LEAN_HEADERS=1 -DQT_MOC_COMPAT -DQT_NO_CAST_TO_ASCII -DQT_NO_CONTEXTLESS_CONNECT -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_QASCONST -DQT_NO_QEXCHANGE -DQT_NO_QSNPRINTF -DQT_NO_STD_FORMAT_SUPPORT -DQT_NO_USING_NAMESPACE -DQT_QPA_DEFAULT_PLATFORM_NAME=\"cocoa\" -DQT_USE_NODISCARD_FILE_OPEN -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/Gui_autogen/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtGui.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/VulkanMemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/D3D12MemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0/QtGui -I/usr/local/Cellar/at-spi2-core/2.56.2/include/at-spi-2.0 -I/usr/local/Cellar/dbus/1.16.2/include/dbus-1.0 -I/usr/local/Cellar/dbus/1.16.2/lib/dbus-1.0/include -I/usr/local/Cellar/glib/2.84.1/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/ffi -I/usr/local/Cellar/libxtst/1.2.5/include -I/usr/local/Cellar/xorgproto/2024.1/include -I/usr/local/Cellar/libxi/1.8.2/include -I/usr/local/Cellar/libxext/1.3.6/include -I/usr/local/Cellar/libxfixes/6.0.1/include -I/usr/local/Cellar/libx11/1.8.12/include -I/usr/local/Cellar/libxcb/1.17.0/include -I/usr/local/Cellar/libxau/1.0.12/include -I/usr/local/Cellar/libxdmcp/1.1.5/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtCore.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/mkspecs/macx-clang -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/corelib -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtDBus -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtDBus.framework/Headers -F/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib -isystem /usr/local/Cellar/glib/2.84.1/include/glib-2.0 -isystem /usr/local/Cellar/glib/2.84.1/lib/glib-2.0/include -isystem /usr/local/opt/gettext/include -isystem /usr/local/Cellar/pcre2/10.45/include -isystem /usr/local/Cellar/harfbuzz/11.2.0/include/harfbuzz -isystem /usr/local/opt/freetype/include/freetype2 -isystem /usr/local/opt/libpng/include/libpng16 -isystem /usr/local/Cellar/graphite2/1.3.14/include -isystem /usr/local/include/freetype2 -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -DNDEBUG -O3 -std=gnu++17 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.sdk -mmacosx-version-min=12.0 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -fapplication-extension -fcf-protection=full -ftrivial-auto-var-init=pattern -fstack-protector-strong -fno-exceptions -Winvalid-pch -Xclang -include-pch -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx -MD -MT qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/atspiadaptor.cpp.o -MF qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/atspiadaptor.cpp.o.d -o qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/atspiadaptor.cpp.o -c /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/atspiadaptor.cpp
In file included from /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:4:
/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/atspiadaptor_p.h:19:10: fatal error: 'atspi/atspi.h' file not found
#include <atspi/atspi.h>
         ^~~~~~~~~~~~~~~
1 error generated.
...
FAILED: qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_constant_mappings.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DENABLE_PIXMAN_DRAWHELPERS -DGL_SILENCE_DEPRECATION -DGui_EXPORTS -DQT_ASCII_CAST_WARNINGS -DQT_BUILDING_QT -DQT_BUILD_GUI_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS -DQT_EXPLICIT_QFILE_CONSTRUCTION_FROM_PATH -DQT_LEAN_HEADERS=1 -DQT_MOC_COMPAT -DQT_NO_CAST_TO_ASCII -DQT_NO_CONTEXTLESS_CONNECT -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_QASCONST -DQT_NO_QEXCHANGE -DQT_NO_QSNPRINTF -DQT_NO_STD_FORMAT_SUPPORT -DQT_NO_USING_NAMESPACE -DQT_QPA_DEFAULT_PLATFORM_NAME=\"cocoa\" -DQT_USE_NODISCARD_FILE_OPEN -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/Gui_autogen/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtGui.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/VulkanMemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/D3D12MemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0/QtGui -I/usr/local/Cellar/at-spi2-core/2.56.2/include/at-spi-2.0 -I/usr/local/Cellar/dbus/1.16.2/include/dbus-1.0 -I/usr/local/Cellar/dbus/1.16.2/lib/dbus-1.0/include -I/usr/local/Cellar/glib/2.84.1/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/ffi -I/usr/local/Cellar/libxtst/1.2.5/include -I/usr/local/Cellar/xorgproto/2024.1/include -I/usr/local/Cellar/libxi/1.8.2/include -I/usr/local/Cellar/libxext/1.3.6/include -I/usr/local/Cellar/libxfixes/6.0.1/include -I/usr/local/Cellar/libx11/1.8.12/include -I/usr/local/Cellar/libxcb/1.17.0/include -I/usr/local/Cellar/libxau/1.0.12/include -I/usr/local/Cellar/libxdmcp/1.1.5/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtCore.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/mkspecs/macx-clang -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/corelib -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtDBus -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtDBus.framework/Headers -F/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib -isystem /usr/local/Cellar/glib/2.84.1/include/glib-2.0 -isystem /usr/local/Cellar/glib/2.84.1/lib/glib-2.0/include -isystem /usr/local/opt/gettext/include -isystem /usr/local/Cellar/pcre2/10.45/include -isystem /usr/local/Cellar/harfbuzz/11.2.0/include/harfbuzz -isystem /usr/local/opt/freetype/include/freetype2 -isystem /usr/local/opt/libpng/include/libpng16 -isystem /usr/local/Cellar/graphite2/1.3.14/include -isystem /usr/local/include/freetype2 -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -DNDEBUG -O3 -std=gnu++17 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.sdk -mmacosx-version-min=12.0 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -fapplication-extension -fcf-protection=full -ftrivial-auto-var-init=pattern -fstack-protector-strong -fno-exceptions -Winvalid-pch -Xclang -include-pch -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx -MD -MT qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_constant_mappings.cpp.o -MF qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_constant_mappings.cpp.o.d -o qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_constant_mappings.cpp.o -c /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/qspi_constant_mappings.cpp
In file included from /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/qspi_constant_mappings.cpp:5:
/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/qspi_constant_mappings_p.h:27:10: fatal error: 'atspi/atspi-constants.h' file not found
#include <atspi/atspi-constants.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
...
FAILED: qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_struct_marshallers.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DENABLE_PIXMAN_DRAWHELPERS -DGL_SILENCE_DEPRECATION -DGui_EXPORTS -DQT_ASCII_CAST_WARNINGS -DQT_BUILDING_QT -DQT_BUILD_GUI_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS -DQT_EXPLICIT_QFILE_CONSTRUCTION_FROM_PATH -DQT_LEAN_HEADERS=1 -DQT_MOC_COMPAT -DQT_NO_CAST_TO_ASCII -DQT_NO_CONTEXTLESS_CONNECT -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_NO_FOREACH -DQT_NO_JAVA_STYLE_ITERATORS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_QASCONST -DQT_NO_QEXCHANGE -DQT_NO_QSNPRINTF -DQT_NO_STD_FORMAT_SUPPORT -DQT_NO_USING_NAMESPACE -DQT_QPA_DEFAULT_PLATFORM_NAME=\"cocoa\" -DQT_USE_NODISCARD_FILE_OPEN -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/Gui_autogen/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtGui.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/VulkanMemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/../3rdparty/D3D12MemoryAllocator -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtGui/6.9.0/QtGui -I/usr/local/Cellar/at-spi2-core/2.56.2/include/at-spi-2.0 -I/usr/local/Cellar/dbus/1.16.2/include/dbus-1.0 -I/usr/local/Cellar/dbus/1.16.2/lib/dbus-1.0/include -I/usr/local/Cellar/glib/2.84.1/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/ffi -I/usr/local/Cellar/libxtst/1.2.5/include -I/usr/local/Cellar/xorgproto/2024.1/include -I/usr/local/Cellar/libxi/1.8.2/include -I/usr/local/Cellar/libxext/1.3.6/include -I/usr/local/Cellar/libxfixes/6.0.1/include -I/usr/local/Cellar/libx11/1.8.12/include -I/usr/local/Cellar/libxcb/1.17.0/include -I/usr/local/Cellar/libxau/1.0.12/include -I/usr/local/Cellar/libxdmcp/1.1.5/include -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtCore.framework/Headers -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/mkspecs/macx-clang -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/corelib -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0 -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtCore/6.9.0/QtCore -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/include/QtDBus -I/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib/QtDBus.framework/Headers -F/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/lib -isystem /usr/local/Cellar/glib/2.84.1/include/glib-2.0 -isystem /usr/local/Cellar/glib/2.84.1/lib/glib-2.0/include -isystem /usr/local/opt/gettext/include -isystem /usr/local/Cellar/pcre2/10.45/include -isystem /usr/local/Cellar/harfbuzz/11.2.0/include/harfbuzz -isystem /usr/local/opt/freetype/include/freetype2 -isystem /usr/local/opt/libpng/include/libpng16 -isystem /usr/local/Cellar/graphite2/1.3.14/include -isystem /usr/local/include/freetype2 -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -DNDEBUG -O3 -std=gnu++17 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.sdk -mmacosx-version-min=12.0 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -fPIC -fapplication-extension -fcf-protection=full -ftrivial-auto-var-init=pattern -fstack-protector-strong -fno-exceptions -Winvalid-pch -Xclang -include-pch -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/build/qtbase/src/gui/CMakeFiles/Gui.dir/cmake_pch.hxx -MD -MT qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_struct_marshallers.cpp.o -MF qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_struct_marshallers.cpp.o.d -o qtbase/src/gui/CMakeFiles/Gui.dir/accessible/linux/qspi_struct_marshallers.cpp.o -c /private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/qspi_struct_marshallers.cpp
/private/tmp/qt-20250509-94777-l74b9p/qt-everywhere-src-6.9.0/qtbase/src/gui/accessible/linux/qspi_struct_marshallers.cpp:7:10: fatal error: 'atspi/atspi-constants.h' file not found
#include <atspi/atspi-constants.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
...
ninja: build stopped: subcommand failed.
...
...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably need to be put as

  on_system :linux, macos: :monterey_or_older do
    depends_on "at-spi2-core"
  end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can rebase after #226148

Copy link
Member
@Bo98 Bo98 Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at-spi2 is only enabled if it was found: https://github.com/qt/qtbase/blob/54894df45db5b3c3b99d281af6696737e8a60ea3/src/gui/configure.cmake#L888. Do you logs of the configure stage where this is being detected as found?

If this is not working, I'd rather explicitly set QT_FEATURE_accessibility_atspi_bridge=OFF if OS.mac? than pull in it as a dependency. The files have /linux/ in their names so I doubt upstream indend it to be for macOS either.

chenrui333
chenrui333 reviewed Jun 24, 2025
View reviewed changes
Formula/q/qt.rb
Comment on lines +140 to +143
# Fix for `invalid use of attribute 'fallthrough'` with GCC <= 12 and gperf >= 3.2
# https://bugreports.qt.io/browse/QTBUG-137278 (fixed in 6.9.2)
patch :DATA

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picking this part into #226148

@stefanb stefanb added the 12 Monterey is specifically affected label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 left review comments

@chenrui333 chenrui333 chenrui333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
12 Monterey is specifically affected CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles ffmpeg FFMPEG use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samumbach @Bo98 @chenrui333 @stefanb
0