8000 docker docker-completion v28.2.1 by calvinit · Pull Request #225057 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

docker docker-completion v28.2.1 #225057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

docker docker-completion v28.2.1 #225057

merged 4 commits into from
May 30, 2025

Conversation

calvinit
Copy link
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://github.com/docker/cli/releases/tag/v28.2.1

@daeho-ro daeho-ro mentioned this pull request May 29, 2025
Closed
6 tasks
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels May 29, 2025
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request autobump labels May 29, 2025
@chenrui333
Copy link
Member

we can try brew bump --open-pr --no-fork --bump-synced docker to see if we can bump them together and then add them into the autobump list.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 30, 2025
@daeho-ro
Copy link
Member

@chenrui333
Copy link
Member
chenrui333 commented May 30, 2025 •
edited
Loading

The test is failed on linux arm, are we good for this?

The test is failed on linux arm, are we good for this?

yeah, it is fine, currently there is linux arm bottle for docker formula either.

the linux arm build got triggered mainly because of the docker-completion formula

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 30, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 30, 2025 04:01
@BrewTestBot BrewTestBot added this pull request to the merge queue May 30, 2025
Merged via the queue into Homebrew:master with commit fffa849 May 30, 2025
14 checks passed
@calvinit calvinit deleted the docker-v28.2.1 branch May 30, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calvinit @chenrui333 @daeho-ro @BrewTestBot
0