8000 osx-trash 0.7.1 (new formula) by danielbayley · Pull Request #225048 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

osx-trash 0.7.1 (new formula) #225048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

osx-trash 0.7.1 (new formula) #225048

merged 2 commits into from
Jun 9, 2025

Conversation

danielbayley
Copy link
Contributor
@danielbayley danielbayley commented May 29, 2025 •
edited
Loading
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Following #123002 (comment), related to morgant/tools-osx#26.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core macos-only Formula depends on macOS labels May 29, 2025
@chenrui333
Copy link
Member 
   ==> /opt/homebrew/Cellar/osx-trash/0.7.1/bin/trash --help
  trash requires Full Disk Access!
  
  Please go to System Preferences > Security & Privacy > Privacy > Full Disk Access,
  press the '+' button, and add:
  
  1. Your terminal application (usually /Applications/Utilities/Terminal.app)
  2. /usr/libexec/sshd-keygen-wrapper (if you plan to connect via SSH)
  Error: osx-trash: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: 1

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 29, 2025
@danielbayley danielbayley force-pushed the tools-osx-trash branch 4 times, most recently from 4b79f23 to af36054 Compare May 29, 2025 12:09
@danielbayley
Copy link
Contributor Author

@chenrui333 I altered the test to get around this limitation…

chenrui333
chenrui333 reviewed Jun 8, 2025
View reviewed changes
@chenrui333 chenrui333 added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 8, 2025
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 9, 2025
@danielbayley danielbayley requested a review from chenrui333 June 9, 2025 10:29
@chenrui333
Copy link
Member

Thanks @danielbayley!

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 9, 2025

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 9, 2025
@BrewTestBot BrewTestBot enabled auto-merge June 9, 2025 13:23
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 9, 2025
Merged via the queue into Homebrew:master with commit 0f4c8ff Jun 9, 2025
14 checks passed
@Bo98
Copy link
Member
Bo98 commented Jun 9, 2025 •
edited
Loading

This needs keg_only :shadowed_by_macos as it's overriding Apple's /usr/bin/trash

@danielbayley danielbayley deleted the tools-osx-trash branch June 9, 2025 13:58
@danielbayley
Copy link
Contributor Author

This needs keg_only :shadowed_by_macos as it's overriding Apple's /usr/bin/trash

There is no /usr/bin/trash on macOS (Sonoma 14.4.1). What version are you using @Bo98?

@Bo98
Copy link
Member
Bo98 commented Jun 9, 2025

It was added in macOS 15.

@danielbayley danielbayley mentioned this pull request Jun 9, 2025
Merged
6 tasks
@danielbayley
Copy link
Contributor Author

It was added in macOS 15.

Ah interesting. I haven’t upgraded yet… Too many things open! 😅

@Bo98 Fixed in #226220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @chenrui333 @Bo98 @BrewTestBot
0