8000 elf2uf2-rs 2.1.1 (new formula) by kpcyrd · Pull Request #224324 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

elf2uf2-rs 2.1.1 (new formula) #224324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Si 8000 gn up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

elf2uf2-rs 2.1.1 (new formula) #224324

merged 2 commits into from
May 28, 2025

Conversation

kpcyrd
Copy link
Contributor
@kpcyrd kpcyrd commented May 21, 2025
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Related to the effort described in #224322

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels May 21, 2025
@kpcyrd
Copy link
Contributor Author
kpcyrd commented May 22, 2025

hm I'm not sure why the build fails, I added this to fix it for Linux but it doesn't seem to be picked up:

  on_linux do
    depends_on "systemd" # for libudev
  end

@chenrui333
Copy link
Member

maybe just remove these binaries?

     * Binaries built for a non-native architecture were installed into elf2uf2-rs's prefix.
      The offending files are:
        /home/linuxbrew/.linuxbrew/Cellar/elf2uf2-rs/2.1.1/share/elf2uf2-rs/examples/hello_serial.elf	(arm)
        /home/linuxbrew/.linuxbrew/Cellar/elf2uf2-rs/2.1.1/share/elf2uf2-rs/examples/hello_usb.elf	(arm)

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 23, 2025
@kpcyrd
Copy link
Contributor Author
kpcyrd commented May 23, 2025

I use them in the test case, I'm not sure if there's another way to pass files from the source code input to the test function.

Something else I could do, now that flip-link is merged: I could add flip-link as a test dependency, compile the example project that comes with it in pkgshare, then use elf2uf2-rs on the resulting binary.

Do you have thoughts on this? :)

@daeho-ro
Copy link
Member

Then there should be another example compiled on intel cpu and split them for each cases.

@kpcyrd
Copy link
Contributor Author
kpcyrd commented May 23, 2025

@daeho-ro it's a tool for firmware development, so even on an x86_64 Macbook you would still use this tool to process arm binaries (I'm not sure if there are any restrictions in the uf2 format, but I'm also not aware of any intel micro controllers).

@chenrui333
Copy link
Member

so even on an x86_64 Macbook you would still use this tool to process arm binaries (I'm not sure if there are any restrictions in the uf2 format, but I'm also not aware of any intel micro controllers).

yeah, I think it makes sense. then we just need to update this file, audit_exceptions/mismatched_binary_allowlist.json

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 28, 2025
@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label May 28, 2025
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label May 28, 2025
@chenrui333 chenrui333 removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 28, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 28, 2025 23:49
@BrewTestBot BrewTestBot added this pull request to the merge queue May 28, 2025
Merged via the queue into Homebrew:master with commit 8f070b4 May 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpcyrd @chenrui333 @daeho-ro @BrewTestBot
0