8000 node 24.1.0 by BrewTestBot · Pull Request #224288 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

node 24.1.0 #224288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

node 24.1.0 #224288

merged 2 commits into from
May 28, 2025

Conversation

BrewTestBot
Copy link
Member
@BrewTestBot BrewTestBot commented May 21, 2025 •
edited by branchvincent
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing alias long dependent tests Set a long timeout for dependent testing labels May 21, 2025
@branchvincent branchvincent mentioned this pull request May 22, 2025
Closed
1 task
@branchvincent branchvincent added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 22, 2025
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 22, 2025
@chenrui333 chenrui333 added the help wanted Task(s) needing PRs from the community or maintainers label May 24, 2025
@bevanjkay bevanjkay removed the automerge-skip `brew pr-automerge` will skip this pull request label May 27, 2025
@BrewTestBot @branchvincent
node 24.1.0
13b16c3 
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 27, 2025
@branchvincent
Copy link
Member

@Homebrew/core are we ok disabling LTO to get this merged? It's now only applicable for sequoia due to needing clang 17 and it appears our ld_classic workaround stopped working as that runner is (presumably) OOM again, dying after 6 hours without any logs (1, 2)

carlocab
carlocab approved these changes May 28, 2025
View reviewed changes
Copy link
Member
@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we ok disabling LTO to get this merged?

Yes, absolutely.

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label May 28, 2025
MikeMcQuaid
MikeMcQuaid approved these changes May 28, 2025
View reviewed changes
Copy link
Member
@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also yes.

@branchvincent branchvincent added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label May 28, 2025
This was referenced May 28, 2025
Merged
Merged
Merged
Merged
@branchvincent
Copy link
Member

Handling these 4 dependents separately

Error: 4 failed steps!
brew test --retry --verbose cdktf
brew test --retry --verbose gitlab-ci-local
brew test --retry --verbose monika
brew test --retry --verbose prism-cli

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @branchvincent has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@p-linnane p-linnane removed the help wanted Task(s) needing PRs from the community or maintainers label May 28, 2025
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 28, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 28, 2025 22:23
@BrewTestBot BrewTestBot added this pull request to the merge queue May 28, 2025
Merged via the queue into master with commit e5620fe May 28, 2025
17 checks passed
@BrewTestBot BrewTestBot deleted the bump-node-24.1.0 branch May 28, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid 8405 MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@carlocab carlocab carlocab approved these changes

@bevanjkay bevanjkay bevanjkay approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
alias bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BrewTestBot @branchvincent @MikeMcQuaid @SMillerDev @carlocab @bevanjkay @chenrui333 @p-linnane
0