8000 swiftly: remove Xcode requirement by SimplyDanny · Pull Request #223532 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

swiftly: remove Xcode requirement #223532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agre 8000 e to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

swiftly: remove Xcode requirement #223532

merged 2 commits into from
May 26, 2025

Conversation

SimplyDanny
Copy link
Contributor
  • Xcode should not be required at runtime.
  • The formula should be able to build and run on all current macOS versions.
  • on_linux block is dead code as the formula is restricted to macOS.

See the discussion that brought this up.

@github-actions github-actions bot added swift Swift use is a significant feature of the PR or issue macos-only Formula depends on macOS autosquash Automatically squash pull request commits according to Homebrew style. labels May 15, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 15, 2025
@SimplyDanny SimplyDanny force-pushed the patch-1 branch 3 times, most recently from 1a246ea to 416789e Compare May 15, 2025 09:12
@SMillerDev
Copy link
Member 
  [51/473] Compiling HTTPTypes HTTPField.swift
  /private/tmp/swiftly-20250515-4821-vmgp57/.build/checkouts/swift-http-types/Sources/HTTPTypes/HTTPFields.swift:16:8: error: no such module 'Synchronization'
   14 | 
   15 | #if compiler(>=6.0)
   16 | import Synchronization
      |        `- error: no such module 'Synchronization'
   17 | #endif  // compiler(>=6.0)
   18 | 
  [51/473] Compiling CNIOLLHTTP c_nio_llhttp.c

@SimplyDanny
swiftly: remove Xcode requirement
a06287f 
* Xcode should not be a requirement at runtime.
* Ventura still relies on Xcode as there is not Swift 5.10+ release available.
* `on_linux` block is dead code as the formula is restricted to macOS.
@SimplyDanny
Copy link
Contributor Author

So at least it seems possible to remove the dependency on Xcode for Sequoia.

@supertxtnet
Copy link
Contributor

See #224646 that is attempting to complete the Linux support

SMillerDev
SMillerDev reviewed May 26, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 26, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 26, 2025 10:05
@BrewTestBot BrewTestBot added this pull request to the merge queue May 26, 2025
Merged via the queue into Homebrew:master with commit 88b59fa May 26, 2025
14 checks passed
@SimplyDanny SimplyDanny deleted the patch-1 branch May 26, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS swift Swift use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimplyDanny @SMillerDev @supertxtnet @BrewTestBot
0