8000 synergy-core 1.17.1 by samumbach · Pull Request #223352 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content

synergy-core 1.17.1 #223352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

synergy-core 1.17.1 #223352

wants to merge 1 commit into from

Conversation

samumbach
Copy link
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
8000

@samumbach
Copy link
Contributor Author
samumbach commented May 13, 2025 •
edited
Loading

I suspect some other adjustments to this formula may be appropriate:

  • update/remove livecheck block
  • update/remove service block
  • consider rename from synergy-core to synergy (and/or introduce a Deskflow formula and/or cask)
    • and adjust any references to synergy-core name, such as in the comment block regarding the license.
  • adjust bin.install_symlink calls
  • adjust test block (I was only able to test on macOS; I'm not sure if the binary names/paths have changed on Linux as well).

@samumbach
Copy link
Contributor Author

See also:

@samumbach
synergy-core 1.17.1
283740e 
- This reverts commit be567cf: "synergy-core: fix livecheck for github API"
- This reverts commit 001800c: "synergy-core: add livecheck (Homebrew#103520)"
@samumbach samumbach force-pushed the synergy-core-1.17.1 branch from d3d302c to 283740e Compare May 14, 2025 15:23
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samumbach @chenrui333
0