reddacted 0.2.6 (new formula) #222620
reddacted 0.2.6 (new formula) #222620
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
| license "MIT" | ||
|
|
||
| depends_on "rust" => :build # Required for building Rust extensions | ||
| depends_on "python@3.11" |
| sha256 "869931b48356f103c9b0a1a38e937faecf2b8c4c6da4fa53f2de41e62e5ee507" | ||
| license "MIT" | ||
|
|
||
| depends_on "rust" => :build # Required for building Rust extensions |
There was a problem hiding this comment.
rust_extension_packages = ["pydantic-core", "regex"] however I can kill the pydantic dependency, it's actually openai's maturin dependency that causes the build to fail without the rust dependency.
The whole “maturin” headache is coming from the Rust-based jiter wheel that got pulled in by the newer OpenAI SDK - all it does is faster json parsing, I might just pin that to an earlier version and drop rust entirely.
btw @SMillerDev I just wanted to say how impressed I am with the review process for homebrew - I've used brew since gosh like 2017 and hosted my own taps for about a year but this is my first time interacting with the core repo and I really appreciate the depth (& the speed!) of the PR comments. Honestly makes me appreciate the whole ecosystem more, thanks again!
| sha256 "826996d74c5aa9f4b6916195547312ac6384bac3810b8517063f293248257b72" | ||
| end | ||
|
|
||
| resource "certifi" do |
There was a problem hiding this comment.
I'd remove this resource and use depends_on "certifi" instead
|
|
||
| test do | ||
| # Verify CLI works | ||
| system bin/"reddacted", "--help" |
There was a problem hiding this comment.
Maybe you can come up with a better test (f.e. reddacted do-something test.txt)? See more about tests here: https://docs.brew.sh/Formula-Cookbook#add-a-test-to-the-formula
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Command outputs:
(base) ➜ homebrew-tap git:(main) ✗ brew audit --strict --new --online reddacted(no output)