qrencode: update stable #221793
Merged
qrencode: update stable #221793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
8000
The homepage for `qrencode` no longer links to tarball files and previous files appear to have been removed in the process, so the `stable` URL now returns a 404 (Not Found) response. The homepage instructs users to download source packages from the GitHub releases page instead. This updates the formula to use the newest tag tarball from GitHub (4.1.1, from 2020-09-28) and adjusts the build steps/dependencies accordingly. While building the formula, I encountered a `qrencode.c:932:9: error: use of undeclared identifier 'VERSION'` error during the `make` step. Looking at `configure.ac`, it appears that `VERSION` is not set like `MAJOR_VERSION`, etc. I've included a patch that adds this change and the formula builds as expected after applying it.
8cad042 to
b49a34d
Compare
|
Version is coming from cmake build and so I have changed to use it. |
daeho-ro
approved these changes
May 26, 2025
chenrui333
approved these changes
May 26, 2025
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The homepage for
qrencodeno longer links to tarball files and previous files appear to have been removed in the process, so thestableURL now returns a 404 (Not Found) response. The homepage instructs users to download source packages from the GitHub releases page instead.This updates the formula to use the newest tag tarball from GitHub (4.1.1, from 2020-09-28) and adjusts the build steps/dependencies accordingly. While building the formula, I encountered a
qrencode.c:932:9: error: use of undeclared identifier 'VERSION'error during themakestep. Looking atconfigure.ac, it appears thatVERSIONis not set likeMAJOR_VERSION, etc. I've included a patch that adds this change and the formula builds as expected after applying it.I'm not sure if this is the best way of handling this but it seems to work. If this patch makes sense to others, I can open an upstream PR for the change but no PRs have been merged since 2020 and the most recent commit is from 2020-09-28, so the project appears to be pretty dormant. At the very least, I will add the patch to the formula-patches repository and update this PR.