8000 apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.4 by botantony · Pull Request #221598 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]

Skip to content

apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.4 #221598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 26, 2025

Conversation

botantony
Copy link
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@botantony
Copy link
Contributor Author

long build label needed

@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Apr 27, 2025
@botantony
Copy link
Contributor Author

Ir also probably should be blocked for now
#221642

@botantony
Copy link
Contributor Author
botantony commented Apr 29, 2025
[ 63%] Building CXX object modules/llm-cache/CMakeFiles/vineyard_llm_cache.dir/ds/kv_cache.cc.o
  cd /private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/build/modules/llm-cache && /opt/homebrew/Library/Homebrew/shims/mac/super/clang++ -DJSON_DIAGNOSTICS=0 -DJSON_DISABLE_ENUM_SERIALIZATION=0 -DJSON_USE_GLOBAL_UDLS=1 -DJSON_USE_IMPLICIT_CONVERSIONS=0 -DJSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON=0 -Dvineyard_llm_cache_EXPORTS -I/private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/thirdparty/libcuckoo -I/private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/src -I/private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/modules -isystem /private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/thirdparty/nlohmann-json -isystem /private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/thirdparty -std=c++17 -DBOOST_PROCESS_VERSION=1 -include boost/process/v1/args.hpp -include boost/process/v1/async.hpp -include boost/process/v1/child.hpp -include boost/process/v1/env.hpp -include boost/process/v1/environment.hpp -include boost/process/v1/io.hpp -include boost/process/v1/search_path.hpp -fPIC                                         -Wall                                         -Wno-attributes                                         -Wno-unknown-pragmas -Wno-class-conversion -Wno-class-memaccess -Wno-defaulted-function-deleted -Wno-deprecated-declarations -Wno-error=c++11-narrowing -Wno-format-truncation -Wno-noexcept-type -Wno-unused-but-set-parameter -Wno-unused-private-field -Wno-unknown-warning-option -Wno-enum-constexpr-conversion -O2 -g -DNDEBUG -std=gnu++17 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -fPIC -fcolor-diagnostics -D_GLIBCXX_USE_CXX11_ABI=1 -DBOOST_SPIRIT_THREADSAFE -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_BIND_GLOBAL_PLACEHOLDERS -DBOOST_NO_CXX98_FUNCTION_BASE -D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION -MD -MT modules/llm-cache/CMakeFiles/vineyard_llm_cache.dir/ds/kv_cache.cc.o -MF CMakeFiles/vineyard_llm_cache.dir/ds/kv_cache.cc.o.d -o CMakeFiles/vineyard_llm_cache.dir/ds/kv_cache.cc.o -c /private/tmp/vineyard-20250428-99614-lj4csa/v6d-0.24.2/modules/llm-cache/ds/kv_cache.cc
  In file included from <built-in>:1:
  In file included from /opt/homebrew/include/boost/process/v1/args.hpp:33:
  In file included from /opt/homebrew/include/boost/process/v1/detail/basic_cmd.hpp:10:
  In file included from /opt/homebrew/include/boost/process/v1/detail/config.hpp:21:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/system_error:151:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/string:549:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/memory:860:
  /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/__memory/shared_ptr.h:294:37: error: calling a protected constructor of class 'arrow::PrimitiveArray'
          ::new ((void*)__get_elem()) _Tp(_VSTD::forward<_Args>(__args)...);
                                      ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/__memory/shared_ptr.h:953:55: note: in instantiation of function template specialization 'std::__shared_ptr_emplace<arrow::BooleanArray, std::allocator<arrow::BooleanArray>>::__shared_ptr_emplace<std::shared_ptr<arrow::DataType>, unsigned long &, const std::shared_ptr<arrow::Buffer>, const std::shared_ptr<arrow::Buffer>, long long &, long long &>' requested here
      ::new ((void*)_VSTD::addressof(*__guard.__get())) _ControlBlock(__a, _VSTD::forward<_Args>(__args)...);
                                                        ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/__memory/shared_ptr.h:962:19: note: in instantiation of function template specialization 'std::allocate_shared<arrow::BooleanArray, std::allocator<arrow::BooleanArray>, std::shared_ptr<arrow::DataType>, unsigned long &, const std::shared_ptr<arrow::Buffer>, const std::shared_ptr<arrow::Buffer>, long long &, long long &, void>' requested here
      return _VSTD::allocate_shared<_Tp>(allocator<_Tp>(), _VSTD::forward<_Args>(__args)...);
                    ^
  /private/tmp/vineyard-20250428-99[614](https://github.com/Homebrew/homebrew-core/actions/runs/14705292870/job/41264341411?pr=221598#step:3:615)-lj4csa/v6d-0.24.2/modules/basic/ds/arrow.cc:587:23: note: in instantiation of function template specialization 'std::make_shared<arrow::BooleanArray, std::shared_ptr<arrow::DataType>, unsigned long &, const std::shared_ptr<arrow::Buffer>, const std::shared_ptr<arrow::Buffer>, long long &, long long &, void>' requested here
    this->array_ = std::make_shared<ArrayType>(
                        ^
  /opt/homebrew/include/arrow/array/array_base.h:284:3: note: declared protected here
    PrimitiveArray(const std::shared_ptr<DataType>& type, int64_t length,
    ^
  1 error generated.
  make[2]: *** [modules/basic/CMakeFiles/vineyard_basic.dir/ds/arrow.cc.o] Error 1
  make[2]: *** Waiting for unfinished jobs....

@daeho-ro daeho-ro added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 3, 2025
@Lukasdoe
Copy link
Lukasdoe commented May 5, 2025

Since the apache-arrow project defines in their cmake files that major versions are incompatible (causing problems with cmake version ranges and major version updates), I would love to have the possibility of installing a specific apache-arrow version via homebrew.

I'd suggest creating an apache-arrow@20 and keep the old configuration as apache-arrow@19 if possible. Is there anything that speaks against this approach?

@botantony
Copy link
Contributor Author

Homebrew is using rolling release distribution model, if the upstream stops to support any software (i.e. don't update it), Homebrew stops doing it too. Other maintainers didn't want to support CMake 3 installation for this exact reason and I doubt they'll make an exception for this package

@chenrui333 chenrui333 mentioned this pull request May 6, 2025
@SMillerDev
Copy link
Member

I'd suggest creating an apache-arrow@20 and keep the old configuration as apache-arrow@19 if possible. Is there anything that speaks against this approach?

Please indicate how this would fill all our criteria for versioned formulas (https://docs.brew.sh/Versions). If it does we can ship an older version.

@botantony botantony force-pushed the apache-arrow branch 2 times, most recently from 722f55f to 565b064 Compare May 13, 2025 17:12
@samumbach
Copy link
Contributor

Confirmed that these changes to apache-arrow and apache-arrow-glib build for me on macOS Monterey 12.7.6, llvm 20.1.4_1 (Homebrew clang version 20.1.4, Target: x86_64-apple-darwin21.6.0), cmake version 4.0.2.

@daeho-ro daeho-ro mentioned this pull request May 15, 2025
@botantony botantony changed the title apache-arrow apache-arrow-glib 20.0.0 apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.3 May 15, 2025
@samumbach
Copy link
Contributor

@botantony I see the PR title and commit message say vineyard 0.24.3 but the URL in the formula is 0.24.4 ?

@botantony botantony changed the title apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.3 apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.4 May 15, 2025
@daeho-ro daeho-ro mentioned this pull request May 15, 2025
@samumbach
Copy link
Contributor

Build error appears to be present in vineyard 0.24.3 and 0.24.4, which include v6d-io/v6d#1852 / v6d-io/v6d#1992 -- this change depends on an unreleased change in libgrape-lite alibaba/libgrape-lite#168.

I don't think we can upgrade vineyard until there's a new release of libgrape-lite or we add this patch (and possibly other prerequisite patches) to libgrape-lite homebrew formula.

@botantony
Copy link
Contributor Author

I do not like using patched resource instead of a formula but at least it should work

@samumbach
Copy link
Contributor
10000 samumbach commented May 19, 2025

@botantony Nice solution! 😄

I had to add "-DCMAKE_DISABLE_FIND_PACKAGE_libgrapelite=TRUE" to get this building on my machine. This might explain the issues on CI (though I saw a different error; I think my build was seeing and using my current libgrape-lite homebrew formula/package install while the CI builds couldn't find a libgrapelite package).

@chenrui333
Copy link
Member

per this comment, v6d-io/v6d#2043 (comment), might need specific libgrape?

@daeho-ro
Copy link
Member

@chenrui333 Yes, but it doesn't published yet.

@oreilles
Copy link

Does this enable support for GeoArrow & GeoParquet ? These formats are currently unavailable on the homebrew release, GDAL indicates that we might need to add a few flags to make them work (https://gdal.org/en/stable/development/building_from_source.html#building-on-macos).

@botantony botantony mentioned this pull request May 26, 2025
botantony and others added 6 commits May 26, 2025 09:16
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>

harlequin: pyarrow 20.0.0

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: botantony <antonsm21@gmail.com>
@daeho-ro daeho-ro removed the test failure CI fails while running the test-do block label May 26, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 26, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 26, 2025 12:09
@BrewTestBot BrewTestBot added this pull request to the merge queue May 26, 2025
Merged via the queue into Homebrew:master with commit 7b87fb3 May 26, 2025
14 checks passed
@botantony botantony deleted the apache-arrow branch May 26, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
0