-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
apache-arrow apache-arrow-glib 20.0.0 vineyard 0.24.4 #221598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ir also probably should be blocked for now |
2e6b348
to
302e832
Compare
|
Since the apache-arrow project defines in their cmake files that major versions are incompatible (causing problems with cmake version ranges and major version updates), I would love to have the possibility of installing a specific apache-arrow version via homebrew. I'd suggest creating an apache-arrow@20 and keep the old configuration as apache-arrow@19 if possible. Is there anything that speaks against this approach? |
Homebrew is using rolling release distribution model, if the upstream stops to support any software (i.e. don't update it), Homebrew stops doing it too. Other maintainers didn't want to support CMake 3 installation for this exact reason and I doubt they'll make an exception for this package |
Please indicate how this would fill all our criteria for versioned formulas (https://docs.brew.sh/Versions). If it does we can ship an older version. |
722f55f
to
565b064
Compare
Confirmed that these changes to apache-arrow and apache-arrow-glib build for me on macOS Monterey 12.7.6, llvm 20.1.4_1 (Homebrew clang version 20.1.4, Target: x86_64-apple-darwin21.6.0), cmake version 4.0.2. |
@botantony I see the PR title and commit message say vineyard 0.24.3 but the URL in the formula is 0.24.4 ? |
Build error appears to be present in vineyard 0.24.3 and 0.24.4, which include v6d-io/v6d#1852 / v6d-io/v6d#1992 -- this change depends on an unreleased change in libgrape-lite alibaba/libgrape-lite#168. I don't think we can upgrade vineyard until there's a new release of libgrape-lite or we add this patch (and possibly other prerequisite patches) to libgrape-lite homebrew formula. |
I do not like using patched resource instead of a formula but at least it should work |
@botantony Nice solution! 😄 I had to add |
per this comment, v6d-io/v6d#2043 (comment), might need specific libgrape? |
@chenrui333 Yes, but it doesn't published yet. |
Does this enable support for GeoArrow & GeoParquet ? These formats are currently unavailable on the homebrew release, GDAL indicates that we might need to add a few flags to make them work (https://gdal.org/en/stable/development/building_from_source.html#building-on-macos). |
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com> harlequin: pyarrow 20.0.0 Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: botantony <antonsm21@gmail.com>
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?