10000 swiftformat: update checksum by daeho-ro · Pull Request #198216 · Homebrew/homebrew-core · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swiftformat: update checksum #198216

Closed
wants to merge 1 commit into from
Closed

swiftformat: update checksum #198216

wants to merge 1 commit into from

Conversation

daeho-ro
Copy link
Member
@daeho-ro daeho-ro commented Nov 19, 2024 •
edited
Loading

update checksum, upstream published it twice.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@daeho-ro daeho-ro added the checksum mismatch SHA-256 doesn't match the download label Nov 19, 2024
@github-actions github-actions bot added the swift Swift use is a significant feature of the PR or issue label Nov 19, 2024
@daeho-ro daeho-ro mentioned this pull request Nov 19, 2024
Closed
4 tasks
@rgoldberg
Copy link
Contributor

@daeho-ro I reported the issue, but I don't know for sure that the upstream published it twice, I was just guessing.

Maybe you know for sure that it was published twice, and that the second publishing was intended, but I just want to ensure that you aren't taking my guess as necessarily being correct.

Thanks for fixing this.

@daeho-ro
Copy link
Member Author
daeho-ro commented Nov 19, 2024 •
edited
Loading

1st

2nd

3rd

Revision of the tag 0.55.0 was changed not even twice but three times.

@rgoldberg
Copy link
Contributor
rgoldberg commented Nov 19, 2024 •
edited
Loading

Asked about checksums in the upstream:

nicklockwood/SwiftFormat#1924

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. upstream issue An upstream issue report is needed labels Nov 19, 2024
@chenrui333
Copy link
Member

#198429

@chenrui333 chenrui333 closed this Nov 21, 2024
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Nov 21, 2024
@github-actions github-actions bot deleted the swiftformat-checksum branch November 21, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
checksum mismatch SHA-256 doesn't match the download CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. superseded PR was replaced by another PR swift Swift use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daeho-ro @rgoldberg @chenrui333
0